Thread: IF - problem

Code:

 #include<iostream.h>
 #include<conio.h>
 int main()
 {
 clrscr();
 int grade,total=0;
 float avg,a=1;
 char z,y,n;
 cout<<"Enter the grade of the student = ";
 cin>>grade;
 do
 {
 cout<<"\nDo you want to enter another grade? (y/n) - ";
 cin>>z;
 if ( z == y )
 {
 cout<<"\nEnter the grade of the student = ";
 cin>>grade;
 }
 if ( z == n )
 {
 cout<<"\nAverage of the student = "<<avg<<endl;
 getch ();
 return 0;
 }
 total=total+grade;
 avg=total/a;
 a++;
 }while ( a == a );
 cout<<"\nAverage of the student = "<<avg<<endl;
 getch ();
 return 0;
 }

In this program..................the problem i am facing is that.............*z* do stores the user entered character in it like *y* or *n* ................but *if (z==y) and if(z==n) isnt working......plz help me.............plzzzzzzzzzzzz

The easy way to do it is to compare the variable z with the character literal 'y' or 'n'. Remove the variables called y and n and use 'y' and 'n' in your if statements.

Also, you did'n initialise the variabels y and n. I assume you want y to be 'y' and n to be 'n', so initialise like this:

y = 'y';
n = 'n';

Good advice, except you'd need two cin.get() calls (or a cin.ignore() and a cin.get()) because of the leftover newline.

Originally Posted by Daved

The easy way to do it is to compare the variable z with the character literal 'y' or 'n'. Remove the variables called y and n and use 'y' and 'n' in your if statements.

thnx mate fer helping me out.......so if we have to store a character in a characater so we will have to put it in ' '
right.....thats where i was lacking............so thnx fer ur help......

Originally Posted by SlyMaelstrom

...and this is a minor issue, but it's proper to cover both cases when using user input in an if statement.

Try this:

Code:

 if ( z == 'y' || z == 'Y' )
 {
     // CODE
 }
 if ( z == 'n' || z == 'N' )
 {
     // CODE
 }

Secondly, you have no reason to use conio.h in your program. Since your not looping, the clrscr() shouldn't be doing anything at the beginning of your program and the getch() can be replaced with cin.get(), which is found in iostream.h.

thnx mate....i ll replace getch() by cin.get()...............thnx ..

Originally Posted by Salem

Your dot key is very sticky - better get it checked out.

yeah ....there is some chemistry going on between moi finger n *dot key*..hehe

Code:

#include <iostream.h>
#include <conio.h>
 int main()
 {
     clrscr();
     int grade,total=0;
     float avg;
     char z;
     
     cout << "Enter the grade of the student = ";
     cin >> grade;
     do
     {
         cout<<"\nEnter the grade of the student = ";
         cin>>grade;
         total=total+grade;
         avg=total/a;
         a++;
         cout<<"play again? y/n"<<endl;
         cin>>z; 
         }while(z == 'y' || z == 'Y'); 
     cout<<"\nAverage of the student = "<<avg<<endl;
     getch ();
     system ("PAUSE")
     return 0;
 }

K just do something liek this i am not sure if it will work cause i never bothered debugging it but it should the as simple as that it asks over and over untill the user presses.. And it is also nice to add system pause so the screen doesn't close and you can run it from compiler........... (i liike the dots as much as u)