Thread: An illegal operation message

This is my code:

Code:

#include <string>
#include <windows.h>
#include <iostream>
#include <algorithm>
using namespace std;
bool DownloadFile(LPCTSTR URL , LPCTSTR LocalFilename); 
typedef long (WINAPI * MYPROC)(long,LPCTSTR,LPCTSTR,DWORD,long);
bool DownloadFile(LPCTSTR URL , LPCTSTR LocalFilename) 
{        
    long lngRetVal;              
	HMODULE hinstLib; 
    MYPROC ProcAdd;                                 
    BOOL fFreeResult, fRunTimeLinkSuccess = FALSE;
	hinstLib = LoadLibrary("urlmon.dll");
  if(hinstLib != NULL)
  { 
	ProcAdd = (MYPROC) GetProcAddress(hinstLib, "URLDownloadToFileA");
	   if (NULL != ProcAdd) 
	   {
            fRunTimeLinkSuccess = TRUE;
		    lngRetVal = ProcAdd(0, URL, LocalFilename, 0, 0);
		    fFreeResult = FreeLibrary(hinstLib);

		}	
  }
}
int main(){
string man;
char est[200];
cout<<"Tere tulemast!";
cin.getline(est,200,'\n');
cout<<"test1";
man=strcat("http://maxorator.farvista.net/man.php?red=",est);
cout<<"test2";
char shelp[200];
*(std::copy(man.begin(), man.end() - man.begin() < 200 ? man.end() : man.begin() + 199, shelp)) = 0;
LPCTSTR URL = shelp;
DownloadFile(URL,"C:\\My Documents\\temp2.abc");
}

It only couts test1, so that means the problem must be in this line:

Code:

man=strcat("http://maxorator.farvista.net/man.php?red=",est);

If I tried to use debug, it displayed the blue screen and closed my compiler(Dev-C++).
Any ideas?

Yep,
The first argument must be a non constant char* variable, cause the second string('est') is appended on to it. but I'm not sure...

All you need:

Code:

	std::string url("http://maxorator.farvista.net/man.php?red="), temp;
	std::getline(std::cin, temp);
	url += temp;
	DownloadFile(url.c_str(), "C:\\My Documents\\temp2.abc");

Stick to std::string's, or char*'s, don't intermix them so. You got the illegal operation because the program was not able to append contents to a string literal in read-only code. Look at a strcat reference for appropriate use. You have a lot of wierd things in your code, keep it simple. You could simply link urlmon into your project too. If you got a bluescreen off of that, ... , yeah.

How can I link it to my project?