Thread: y wont this work this way

ok this isnt my code its my cuz that im tryin to understand and make simpler....

i wanna know i have to do
molecular check;
and molecular temp;

Code:

unsigned storeData(ifstream & ifs,vector <molecular>& m) 
{ 
	molecular check; //temporary to read in files
	string name; 
	string formula; 
	unsigned max(0);
	char ch;
	
	while(ifs>>name>> ch >> check.carbon >> ch >> check.hydrogen)  
	{ 
		molecular temp; 
		unsigned c = check.carbon;
		unsigned h = check.hydrogen;

		if(!exists(m,c,h))//if this is a new formula 
		{ 
			temp.names.push_back(name); 
			temp.carbon=c; 
			temp.hydrogen=h; 
			m.push_back(temp);//create this molecule and push it into the vector 
				if(c>max) 
					max=c; 
		} 
		
		else//check if this name already exists and if it doesnt push it back 
		{   //on the names vector 
			for(size_t i=0;i<m.size();i++) 
				if(m[i].carbon==c && m[i].hydrogen==h && !nameExists(m,name,c,h)) 
				{ 
					m[i].names.push_back(name); 
				} 
		} 
	} 
	
	return max; 
}

if i put just molecular temp here

Code:

		molecular temp; 
	string name; 
	string formula; 
	unsigned max(0);
	char ch;
	
	while(ifs>>name>> ch >> temp.carbon >> ch >> temp.hydrogen)  
	{

and run the program it gives me wrong output...
any1 know y i have to do molecular check and temp and not just do one temp outside the loop

b/c like i said im tryin to make it simpler and im changing something more complex that he did. ive already deleted and changed da code he created...
and if u want to come off sarcastic and not help then dont post and move on

i kno the purpose of the prog and everything and his program works perfectly fine... we both had 2 do the same prog but we did it in class and we did it differently.. so in this persons code they used atoi() 2 find convert the string which the school doesnt want and i changed it .... just my problem was y do i have 2 create to temporary
molecular check;
and mocleculary temp;

instead of just doing

Code:

unsigned storeData(ifstream & ifs,vector <molecular>& m) 
{ 
	molecular temp;
	string name;
	unsigned max(0);
	char ch;
	
	while(ifs>>name>> ch >> temp.carbon >> ch >> temp.hydrogen)  
	{ 
		unsigned c = temp.carbon;
		unsigned h = temp.hydrogen;

		if(!exists(m,c,h))//if this is a new formula 
		{ 
			temp.names.push_back(name); 
			temp.carbon=c; 
			temp.hydrogen=h; 
			m.push_back(temp);//create this molecule and push it into the vector 
				if(c>max) 
					max=c; 
		} 
		
		else//check if this name already exists and if it doesnt push it back 
		{   //on the names vector 
			for(size_t i=0;i<m.size();i++) 
				if(m[i].carbon==c && m[i].hydrogen==h && !nameExists(m,name,c,h)) 
				{ 
					m[i].names.push_back(name); 
				} 
		} 
	} 
	
	return max; 
}

it seems wierd to me that because i declare temp outside the loop it suddenly gives me wrong output.

4get it ... i realized i had to add this ....
temp.names.clear();

Originally Posted by gamer4life687

4get it ... i realized i had to add this ....
temp.names.clear();

Yeah, because of !exists(m,c,h), would consider the old values in temp, because moving it outside the while statement would prevent it from resetting every time, right? wrong? hmm.

exactly right and thats the reason my cousin converted the string to an int im guessing. from the looks of it he couldnt figure out how to read each individual part and clear the names... but thx its working now