code condensing

**bcianfrocca** · 09-07-2005

When i do this code, it gives me multiple entries of the same data... for instance, in the "big10.txt" file, after the program is run with this code now in it...

Code:

for (int n=0; n<10; n++)
		{
			if (pac10[n]==info.college)
				file_op<<info.firstName<<","<<info.lastName<<","<<info.yearsExp<<","<<info.college<<","<<info.nflTeam<<endl;
		}

it is giving me this in my text file...

Code:

 Matt , Katula,0,Wisconsin,Baltimore Ravens
 Matt , Katula,0,Wisconsin,Baltimore Ravens
 Matt , Katula,0,Wisconsin,Baltimore Ravens
 Matt , Katula,0,Wisconsin,Baltimore Ravens
 Matt , Katula,0,Wisconsin,Baltimore Ravens
 Matt , Katula,0,Wisconsin,Baltimore Ravens
 Matt , Katula,0,Wisconsin,Baltimore Ravens
 Matt , Katula,0,Wisconsin,Baltimore Ravens
 Matt , Katula,0,Wisconsin,Baltimore Ravens
 Matt , Katula,0,Wisconsin,Baltimore Ravens
 Matt , Katula,0,Wisconsin,Baltimore Ravens
 Lee , Evans,2,Wisconsin,Buffalo Bills
 Lee , Evans,2,Wisconsin,Buffalo Bills
 Lee , Evans,2,Wisconsin,Buffalo Bills
 Lee , Evans,2,Wisconsin,Buffalo Bills
 Lee , Evans,2,Wisconsin,Buffalo Bills
 Lee , Evans,2,Wisconsin,Buffalo Bills
 Lee , Evans,2,Wisconsin,Buffalo Bills
 Lee , Evans,2,Wisconsin,Buffalo Bills
 Lee , Evans,2,Wisconsin,Buffalo Bills
 Lee , Evans,2,Wisconsin,Buffalo Bills
 Lee , Evans,2,Wisconsin,Buffalo Bills

**elad** · 09-07-2005

It looks like you probably have a nested loop somewhere where you don't need one. The code could I would use would probably look like this in pseudo code:

Code:

while(read in first line of player data)
   read in rest of player data
   display player data
 
   //set a flag each time through to false
   shool found equals false
 
   //look for players school among the pac10 and big10 schools
   for each pac10 school
	 if pac10 shool name equal college name of player
		write player data to pac10 file
		school found equal true
		break;
 
   //if school not found in pac10 look in big10
   if not school found
	 for each big10 school
	   if big10 school name equal college name of player
		  write player data to big10 file
		  break

Thread: code condensing

Thread Tools

Search Thread

Display

Hybrid View

Similar Threads

Enforcing Machine Code Restrictions?

Values changing without reason?

Obfuscated Code Contest

Interface Question

Who will map the scan code (inserted by VKD_Force_keys) to virtual key code?