Thread: Help with "cin" in C++

Hello, I am somewhat I newbie to C++ programming and I require some help with this. I am writing a simple organizer program but I run into a problem: I run it and it gives me the main menu, and I enter an option, but then it just blows off the option number and gives me the next function in the code. Here is the code:

life.cpp

Code:

#include <iostream.h>
#include "menu.cpp"
using namespace std;
int main()
{
	int answerget;
	startmenu();
	cin >>answerget;
	if (answerget = "1")
			contactsmenu();
	if (answerget = "2")
			notepadmenu();
	if (answerget = "0")
			cout << "\nGood Bye\n";
			return 0;
}

main.cpp

Code:

void startmenu()
{
	cout << "\nWelcome to Life V.00001";
	cout << "\n Select option number:";
	cout << "\n[1]Contacts";
	cout << "\n[2]Notepad";
	cout << "\n[0]Quit\n";
}

void contactsmenu()
{
	int contactmget;
	cout << "\n CONTACTS--";
	cout << "\n\n[A]List Contacts";
	cout << "\n[B]Add Contact";
	cout << "\n[C]Edit Contact";
	cout << "\n[Q]MainMenu\n";
	cin >> contactmget;
	if ( contactmget = 0)
			startmenu();
}

void notepadmenu()
{
	int notepadmget;
	cout << "\n NOTEPAD--";
	cout << "\n\n[1]New File";
	cout << "\n[2]Open File";
	cout << "\n[0]MainMenu\n";
	cin >> notepadmget;
	if ( notepadmget = 0)
			startmenu();
}

Can anyone help me out?

Try this:

Code:

#include <iostream.h>
#include "menu.cpp"
using namespace std;
int main()
{
	int answerget;
	startmenu();
	cin >>answerget;
	if (answerget == 1)
			contactsmenu();
	if (answerget == 2)
			notepadmenu();
	if (answerget == 0)
			cout << "\nGood Bye\n";
			return 0;
}

See the errors?

first of all your using deperciated header (iostream.h)
and i guess its a prefrence but i look at it as good
programming to use brackets*.


*like with your if statments


you also might possibly consider using cin.ignore();
after your cin>> statments to take the newline
character off the buffer as to not mess up any other
cin>> statments.

Code:

#include <iostream.h>
#include "menu.cpp"
using namespace std;
int main()
{
        int answerget;
        startmenu();
        cin >>answerget;
        cin.ignore(); // you only need it here

        // the reason why it didnt work here is because you forgot brackets "{" and "}".
        // for more than one statement you need brackets.
        if (answerget == 1)
                        contactsmenu();
	if (answerget == 2)
                        notepadmenu();
        if (answerget == 0)
                        cout << "\nGood Bye\n";
                        return 0;
}

yea i forgot to mention on this
you use "=" to set somethign equal to something

you use "==" for comparison purposes

it mess up the cin >> statment by going pass the statement
if \n is on the buffer, cin.ignore() get it off the buffer so as not
to affect the other cin >> statments.

Post an example of this baffling behaviour.

Where do you see cin.get() in the poster's code?

cin.get() just to keep it open to see the result
had nothing to do with the code i posted.

anyways the ignore let you handle
say if you have char, and the user types


abcde but char only holds one, all the character left on the
buffer will go into the next statements,
so use something like cin.ignore(80, '\n');

to get rid of everything left on the buffer before the next cin >>
statment as nto to mess it up.

sorry if i was unclear by just saying newline, i ment up to the
newline

Code:

cout << "\n\n[A]List Contacts";
cout << "\n[B]Add Contact";
cout << "\n[C]Edit Contact";
cout << "\n[Q]MainMenu\n";

i guess that would be my mistake that
he was reading with a int, when accoding
to these statments he seems to wants a character
input.

Thanks guys. Right now, it works as programmed. However, on the contact and notepad menus, I press "0" and it takes me back to the main screen but then it quits. This is expected since all my cin stuff is in my int main. When I try to rearrage the code, forexample: putting int answerget and cin >> answerget in startmenu(), I get a lot of different errors. Is there any good way to rearrange this? Or to use the main fuction again?