Thread: Help 4 newbie w/ I/O into array

The first part I'm having trouble with is having the user type in the file name to read in to the array.

Second, I need to count the occurance of each element of the array and display the element next to it's number of occurances.

The text file looks like this: 1 2 3 2 6 7 4 5 3 7 4 5 2 4 7

Please help me!

My code looks like this: (Don't laugh)

\#include <iostream>
#include <fstream>
#include <cstdlib>
#include<string>

using namespace std;

void sort(char a[], int number_used);

void swap_values(char& v1, char& v2);

int index_of_smallest(const char a[], int start_index, int number_used);

Code:

int main()
{
	char input_file[21];
	int number_used;
	ifstream in_stream;
	in_stream.open(input_file);
	
	
	cout<< "Please enter the name of the input file.\n";
	cin>> input_file;
	cin.read(input_file, 21);
	sort(input_file, number_used);
	while (!in_stream.eof())
	{
		for (int index = 0; index < number_used; index++)
		cout<< input_file[index] << " \n";
	
		in_stream.close();
	}
	
	return 0;
}

void sort(char a[], int number_used)
{
int index_of_next_smallest;
for (int index = 0; index < number_used - 1; index++)
{
index_of_next_smallest = index_of_smallest(a, index, number_used);
swap_values(a[index], a[index_of_next_smallest]);
}
}

void swap_values(char& v1, char& v2)
{
int num;
num = v1;
v1 = v2;
v2 = num;
}

int index_of_smallest(const char a[], int start_index, int number_used)
{
int min = a[start_index],
index_of_min = start_index;
for (int index = start_index + 1; index < number_used; index++)
if (a[index] < min)
{
min = a[index];
index_of_min = index;
}
return index_of_min;
}

We'll need a permission slip from your teacher

Code:

getline(cin, string, '\n');

file.open(string.c_str, ios::in);

while(!file.fail())
{
    file >> myINT;
    vectorint.push_back(myINT);
}

there i didnt declare any variable for you
youll have to do that, and i didnt do the last part
for you cause im lazy, but maybe some more
help will be provided soon as you show people what youve
done and where your having problems.

Originally Posted by ILoveVectors

there i didnt declare any variable for you

...Which is a fairly simple and mindless task. Try not to post solutions for homework problems.

<pedantic>
I have to wonder how you would declare those variables, considering that you didn't fully qualify getline. From that, one could guess that you'd have either a using std::getline; or a using namespace std;. Then how would you create a std::string named string?

Code:

getline(file, string, '\n');

You could fully qualify the variable declaration (std::string string;), but it seems inconsistent to do so after you've already used a using statement above for getline.
</pedantic>

Further, vectors can work in this situation, but aren't really ideal. A map<int,int> makes it much simpler. Additionally, the OP said he was reading the numbers into an array, which makes me believe that the class hasn't yet learned any STL.

To the OP: Show us your attempt, and we'll see what we can do to help you.

it was kind of a sarcastic post, ive seen you guy do it many
time figured i could of. not to mention with there being alot
wrong its not really a solution, but it an idea.