n00b problems

[piebob]

Hi, I am a big n00b using dev c++. I tried to make a sort of calculator using what I have learnt so far from the tutourials but I get lots of compile errors and have no idea what is going on.

#include <iostream>
#include <fstream>
using namespace std;

int problem(int x, int y, int z, short operation);

int main()
{
    int x;
    int y;
    int z;
    bool q = 0;
    short operation;
    
    cout<<"Enter operation. Then x and y.";
    for(q = 0);
    {
        cout<<"1.* \n 2./ \n 3.- \n 4.+";
        cin>>operation;
        cin>>x>>y;
        problem(x, y, z, operation);
        cout<<"Quit? [0/1]";
        cin>>q;
    }
    cin.get();
    return 0;
}

int problem(int x, int y, int z, short operation)
{

    switch (operation)
    {
           case 1:
                x * y = z;
           case 2:
                x / y = z;
           case 3:
                x - y = z;
           case 4:
                x + y = z;
    };
    return z;
}

These are the compiler errors.

      In function `int main()': 
16  expected `;' before ')' token 
17  expected primary-expression before '{' token 
17  expected `;' before '{' token 
17  expected primary-expression before '{' token 
17  expected `)' before '{' token 
      In function `int problem(int, int, int, short int)': 
34  non-lvalue in assignment 
36  non-lvalue in assignment 
38  non-lvalue in assignment 
40  non-lvalue in assignment

Can you tell me wat im doing wrong?

[ay_okay]

Alright, I corrected your code and I will explain what I did.

#include <iostream>
#include <fstream>                              //<----why are you using this? Its only for reading
using namespace std;                            and writing files

int problem(int x, int y, short operation);             //doesn't need int z

int main()
{
    int x;
    int y;
    int z;
    bool q = true;
    short operation;
    
    cout<<"Enter operation. Then x and y."<<endl;
    while(q)
    {
        cout<<" 1.* \n 2./ \n 3.- \n 4.+"<<endl;
        cin>>operation;
        cin>>x>>y;
        z = problem(x, y, operation);           //if you return something,  you need to make it return
        cout<<"Your answer is "<<z<<endl;       //to something, like z.
        cin.get();                               //<---on my comp, when i pressed enter it went too
        cout<<"Quit? [0/1]";                     //fast so i put this in to slow it down. 
        cin>>q;
    }
    cin.get();
    return 0;
}

int problem(int x, int y, short operation)      //you don't need z because you can identify it in
{                                               //the function then return it.
    int z;
    switch (operation)
    {
           case 1:
                z = x * y;                      //all your equations must have z = first 
                break;                          //you need break or it'll mess up and the 
           case 2:                              //answer will always be addition
                z = x / y;
                break;
           case 3:
                z = x - y;
                break;
           case 4:
                z = x + y;
                break;
                
    };
    return z;
}

[piebob]

Thanks, it worked heaps well. Cya