Thread: trouble with checking a string..

Code:

#include<iostream>
#include<cstring>
using namespace std;

int main()
{
    string old_name;
    // presumably assign old_name somewhere in here.
       
    if(!old_name.empty()) // easy to read conditional.
    {
        char* new_name = new char[4];
        strncpy(new_name, old_name.c_str(), 4);
        // do what you got to do with a non-empty c-string
        // All the messy c-string work is isolated here.
        
        cout << new_name << endl;
    }
    else
    {
        cout << "empty" << endl;
    }
    
    cin.get();
    return 0;
}

ah, I see what you meant... I generally try not to change the logic of the OP, because, for example, he may have intended to copy the string into the array wether or not it was empty. for example, if this code is being used to change/remove a password, your version would require that something was put in, where the OP code may have thrown a warning and continued on it's merry way with it's empty char*.

in this case, however, it probably doesn't matter.