Thread: Revaluing x and cin.get(); needed in if

If I were making a if thing say

Code:

include <iostream>
using namespace std;
int main()
{
cout<<"Please select 1 or 0\n";
cin<< x;
cin.ignore;
if ( x == 0 ) {
cout<<"Hi, you were wrong, please choose again\n";
cin<< x;
cin.ignore
if ( x == 1 ) {
cout<<"Yay, you got it right!\n";
cin.get();
}
else if ( x == 1 ) {
cout<<"Well done!\n";
cin.get();
}
else {
cout<<"I said 1 or 0, pick again!\n";
cin<< x;
cin.ignore;
if ( x == 1 )
cout<<"Yay!\n";
}

Do I need the cin.get(); and how do you revalue x? Don't worry about other mistakes I just made this up on the spot. Thanks

idont know!!

Thanks... Anyone else have any idea?

>> Don't worry about other mistakes I just made this up on the spot.
Few people will be inclined to help if the code isn't readable. Proper indentation, compilable code, and concise questions are always advised.

In the meantime, there may some FAQ entries that are of interest.

gg

Short answer: No.
Slightly longer answer: Fix your code, kthx.

Despite it all, your code I can read through no prob...

It's your question that I find myself at a loss. Can you elaborate, or rephrase?

Unless you explicitly declare x as a constant (ie... const int x = 5) then you can change it whenever you like.

The cin.get() seems to be used in this example just to pause the program until the user hits enter to continue. So whether you need it is up to you.

Also the use of cin.ignore should be cin.ignore(). And I personally feel cin.ignore() is not a very reliable method of flushing the input stream. If there's more than one character in the input stream, cin.ignore() will only flush the next character (the default with no parenthesis is one char). If you want to be sure the input stream is clear, use while ( cin.get() != '\n' );.

Thanks alot! So I can redefine x at any moment? I was about to try it but an error comes up when I try this code

Code:

#include <iostream>
using namespace std;
int main()
{
    int x;
cout<<"Please select 1 or 0\n";
cin>> x;
cin.ignore();
if ( x == 0 ) {
cout<<"Hi, you were wrong, please choose again\n";
cin>> x;
cin.ignore();
if ( x == 1 ) {
cout<<"Yay, you got it right!\n";
cin.get();
}
else if ( x == 1 ) {
cout<<"Well done!\n";
cin.get();
}
else {
cout<<"I said 1 or 0, pick again!\n";
cin>> x;
cin.ignore();
if ( x == 1 ) {
cout<<"Yay!\n";
}
}

Is says:
28 C:\Documents and Settings\Chris\My Documents\My game\cout.cpp syntax error at end of input
and
C:\Documents and Settings\Chris\My Documents\My game\cout.cpp In function `int main()':

What does this mean and how can I get this to work?

Thanks

Originally Posted by ballmonkey

Thanks alot! So I can redefine x at any moment? I was about to try it but an error comes up when I try this code



Is says:
28 C:\Documents and Settings\Chris\My Documents\My game\cout.cpp syntax error at end of input
and
C:\Documents and Settings\Chris\My Documents\My game\cout.cpp In function `int main()':

What does this mean and how can I get this to work?

Thanks

It means you don't have enough closing '}'. You can get it to work by supplying a couple more of them. It might help if you used indentation, as was previously suggested. Here is a possibility:

Code:

#include <iostream>
using namespace std;
int main()
{
    int x;

    cout<<"Please select 1 or 0\n";
    cin>> x;
    cin.ignore();

    if ( x == 0 ) {
        cout<<"Hi, you were wrong, please choose again\n";
        cin>> x;
        cin.ignore();
        if ( x == 1 ) {
            cout<<"Yay, you got it right!\n";
            cin.get();
        }
        else if ( x == 1 ) {
            cout<<"Well done!\n";
            cin.get();
        }
        else {
            cout<<"I said 1 or 0, pick again!\n";
            cin>> x;
            cin.ignore();
            if ( x == 1 ) {
                cout<<"Yay!\n";
            }
        }
// What's missing here?

Your problem is that you're missing a couple of closing brackets. You really should indent your code so you can better spot where they are missing.

You're missing two }'s in your code.

Oh, oops. I feel like a complete idiot... hee hee. Thanks guys!