Thread: Broken While Loop

i have a broken while loop on my hands. I know how to code the arguments but the arguments take one loop more than they should.

my code looks something like this...

Code:

while((monsterhp>0)&&(playerhp>0))
{
  //player attacks using magic or item
  monsterhp-=damage;
  //monster now attacks
  playerhp-=damage;
  //yes the damage int does change since last time i used it.
}

when i run the program it takes one extra turn to pick up that one or the other is dead.

if you need morecoding just say so and ill try to be more in depth.

Q: It takes one extra while loop iteration to reach your resolution? A: change while((monsterhp>0)&&(playerhp>0)) to while((monsterhp>1)&&(playerhp>1))



C++ == easy

A: change while((monsterhp>0)&&(playerhp>0)) to while((monsterhp>1)&&(playerhp>1))

Unless I'm wrong that will end the loop prematurely. That will end the loop when either the monster or the player reaches 1 or lower not 0 or lower.

Give us some more code. The code that you posted should work, so the problem is elsewhere.

the only other code really that is after that is as follows.

Code:

//after while loop

if(monsterhp>playerhp)
cout<<"I'm sorry you have lost.";
else
cout<<"Congrats you won!";

thats pretty much all i have so i dont know why it isnt working.

All the code you've posted has worked. The problem is in code that you haven't posted.

thats wat im tryin to tell you the only othercode i have are functions that deal damage to the monster or the player.

and i know those are rite but ill try to post them later today to prove to you doubters.