Changing all characters in string to ASCII value of one up...help!

[U79]

I need to make a program that changes all the ASCII values of the characters in a string to one ASCII value above the ones in the string, so "ABCDEF" would become "BCDEFG" and "apple" would become "bqqmf", for examples. This is what I have so far, and it's way off:

// PROJECT 10-2.CPP
// By Josh Milewski

#include<iostream>
using namespace std;

main()
{
	const int size = 21;
	char x[size];
	cout << "Input a string: ";
	cin.get(x,size);
	for(char y = x[0]; y < x[20]; y = y++)
	{
		cout << y++;
	}
	cout << '\n';
	return 0;
}

Please help me! Thank you very much!

[[Ren]]

Because you using ASCII, just add 1 to each string character.

#include <iostream>
#include <string>

using namespace std;

int main()
{
    string s;

    cout << "Enter a string> ";
    if (!getline(cin, s)) {
        cerr << "Input failure" << endl;
        return 1; // Ren is still lazy
    }
    for (string::size_type i = 0; i < s.length(); ++i)
        ++s[i];
    cout << s <<endl;

    return 0;
}

[Stack Overflow]

Hello,

The word "apple" is 97 112 112 108 101 in ASCII. A good reference is ASCIITable.com. So for example, 'A' is a character constant; in the ASCII character set its value is 65, the internal representation of character A. If this makes sense, we can increment the value of an array subscript by using the ++, increment, operator.

For example, take a character array word[3] and store "Hi". Logically, word[0] will be 'H' which is 72 in ASCII. If we increment the value of the array subscript, we can modify the internal representation:

++word[0]; // Increment value

To modify each index you can create a for loop that loops from 0 to the length of your string. During each loop you can execute the code to increment your variable subscript.

Note: [Ren] showed an example of how to do it.


- Stack Overflow

[hk_mp5kpdw]

You loop need to go from index 0 up to (not including) index of the length of the string. The length of the string is NOT necessarily the size of the character array. Unless you want to loop through and find the NULL character in order to get the length, I'd suggest using the strlen function declared in the cstring header. Inside your loop, you should display the preincremented value of the character at the current index.

#include<iostream>
#include <cstring>  // For the strlen function
using namespace std;

int main()
{
    const int size = 21;
    int len;
    char x[size];
    cout << "Input a string: ";
    cin.get(x,size);
    len = strlen(x);
    for(int y = 0; y < len; ++y)
    {
        cout << ++(x[y]);
    }
    cout << '\n';
    return 0;
}

If you do not take into account the true length of the string (not the size of the character array), you will end up going through the whole array and incrementing possible junk values (including the NULL terminating character wherever it may happen to be in the array).

Of course, the above simply displays the values stored in the array in a different (one up) form and does not actually change them to what is being displayed which was what your post said you wanted. To do that you will need to assign the new values to the old positions... Also what do you want to have happen with the 'Z' and 'z' characters?

[jEssYcAt]

#include<iostream>
using namespace std;

main()
{
	const int size = 21;
	char x[size];
	cout << "Input a string: ";
	cin.get(x,size);
	for(char y = x[0];  y < x[20];  y = y++)
	{
		cout << y++;
	}
	cout << '\n';
	return 0;
}

Your code is way off because you are using the highlighted variables in ways that you are not intending.

You are initially setting your counter variable to "the value of the first element of the x[] array", and setting the condition of the for loop to be "as long as y is less than the value of the 21st element of the array x[]". (remember arrays start counting at 0, so 0 is the first element, and the index 20 is the 21st element). Next, in the for loop you are just incrementing the counter variable which does not change anything in the x[] array.

Edit: See what happens when you take forever to type something while at work?

[U79]

Happiness has become me! Thank you so much, everybody! Here is the code I am using that works!

// PROJECT 10-2.CPP
// By Josh Milewski

#include<iostream>   // replaces crazy old iostream.h
#include<cstring>   // needed for strlen function
using namespace std;   // fixes namespacing issues in iostream

int main()
{
    const int size = 500;
    int len;
    char x[size];   // character called x of size 500
    cout << "Input a string: ";
    cin.get(x, size);   // gets x up to 500 characters
    len = strlen(x);   // len equals the length of x
    cout << "Encrypted: ";
    for(int y = 0; y < len; ++y)   // y is 0, the first character of x
    {                              // and as long as y is less than the length of x
        cout << ++(x[y]);          // the y of x plus one
    }                              // then adds one to y and starts over
    cout << '\n';
    system ("pause");
    return 0;
}

Again, thank you very much!