Thread: Trouble reading from file

I need to read this delimited file into a program using a loop. Each iteration of the loop. the data will be inserted into a tree data structure, but the way I have the loop written, it runs infinately. Please help.

File contents:

Code:

firstName|lastName|City|State|Zip\n

Code:

    while(!inf.eof()) {

        inf.getline(ffirst, 15, '|');
        inf.getline(flast, 20, '|');
        inf.getline(fcity, 25, '|');
        inf.getline(fstate, 2, '|');
        inf.getline(fzip, 10, '\n');

        insert(ffirst, flast, fcity, fstate, fzip); // Insert data into binary tree

    }

Several things
1. how did you declare ffirst etc
2. Have you read the FAQ about why eof() is not the best way to detect when you've read a complete file
3. Where are your error checks on each of your getline calls.

Code:

    char ffirst[15];
    char flast[20];
    char fcity[25];
    char fstate[2];
    char fzip[10];

I'm really just unsure as to why this isn't working. It should just terminate the loop at the end of the file.

> char fstate[2];
Well take states for an example "CA"
This takes 3 chars - two for the two letters, and one for the \0

Just to make it easier to change, try

Code:

inf.getline(fstate, sizeof fstate, '|');

I see that. But why isn't inf.eof() detecting that I'm at the end of the file? I looked at the tutorial, and it didnt' have anything on eof(). I've been looking around on the net for something, but I'm not having any luck.

I just want to know why my loop is running infinately and what I need to do to stop it. What error check am I missing?

it didnt' have anything on eof()

That's why you were referred to the FAQ - It's listed as a forum on the main page.

What error check am I missing?

You're not checking for success on each of your calls to getline.