Thread: binary search tree

if anyone has time to help me....i am missing something that i cannot see. the value of x is supposed to be transferring to p->info but it does not. i cant figure out why. because of this, the expression cannot be evaluated and the recursive function cycles infinitely forcing the program to crash. i have tried everything i can think of over the past 5 days and i am out of ideas.

i followed the instructor's demonstration as best i could, but apparently i missed something. if anyone can see what i am doing wrong here, i would greatly appreciate the help.

Code:

#include <iostream>
#include <cstring>  // the node.info was previously a string variable, changed to INT till i figure this out

using namespace std;

struct node
{
	int info;
	node *left;
	node *right;
};

	node *root;
	root=new(node);
	root=NULL;

void insert(node *&p, int x);  // prototype


void main()
{
	int month;
	for(int i=1; i<=7; i++)
	{
		cout<<"Enter a value: "; 
		cin>>month;
		insert(node *&root, month);
	}
}  //end MAIN


void insert(node *&p, int x)
{
	if (p==NULL)
	{
		p=new(node);
		p->info=x;  
		p->left=NULL;  // debugger always halts here
		p->right=NULL;
	};
	else if(x < p->info)
		insert(p->left, x);
	else insert(p->right, x);
}

Just a few comments in red below after a quick glance:

Code:

#include <iostream>
#include <cstring> 
using namespace std;

struct node
{
    int info;
    node *left;
    node *right;
};

node *root;      // Should be in main
root=new(node);  // Get rid of this
root=NULL;       // This belongs in main

void insert(node *&p, int x);  // Probably not how you want the parameter declared

void main()  // main always return an int
{
    int month;
    for(int i=1; i<=7; i++)
    {
        cout<<"Enter a value: "; 
        cin>>month;
        insert(node *&root, month);  // Wrong way to call the function
    }
}  //end MAIN


void insert(node *&p, int x)  // See prototype comments above
{
    if (p==NULL)
    {
        p=new(node);
        p->info=x;  
        p->left=NULL;  // debugger always halts here
        p->right=NULL;
    }; // This semicolon should not be here
    else if(x < p->info)
        insert(p->left, x);
    else insert(p->right, x);
}

thanx for the hlp, i tried what u suggested and it appears to have worked. but why is the int main important? i've been usig void main all the time. did it make a difference in this case, or is it just a better strategy?

int main is the way the standard is written, and it provides a testable value for successful program execution.
check this site on void main
http://users.aber.ac.uk/auj/voidmain.shtml
google.com is your friend.