Thread: function breakdown

Good evening:
I have finally "fixed" (really, many people here helped, ) my code, and now it compiles error-free which is nice; Upon runtime, though, it is apparent that the primary goal of this snippet of code is not accomplished, that is, "return the substring ("good") and allow it to act as a trigger for a function, a Boolean result which spits out a cout." Very relieved no errors at this point, but little designed results. Just some hints, etc should anyone care to assist.

Thank-you,
reRanger

Code:

#include <stdio.h>
#include <fstream>
#include <iostream>
#include <string.h>
#include <windows.h>

using namespace std;

int main()
{
char str[]="good"; 
char grabber[256];


cout<< "Hello, how are you today?\n"<< endl;                     
cin.getline(grabber,256);

char * pch;
pch=strstr (str, "good"); //Searching for “good” in  ^ Char str


if(pch !=NULL) 

cout<< "I am glad to hear you are doing well today."<< endl;                      
else
cout<< "Is anything wrong at all? Would you like to discuss it? \n"<< endl;                      




Sleep(50000);

return 0;  //END

    }

Look at your call to strstr again. What are you comparing to what?

First of all you have to change..

Code:

pch = strstr(str, "good");

by..

Code:

pch = strstr(grabber, "good");

because str will always contain "good".. you are looking for it in grabber (the user's input..).

then you got the great problem..

strstr() will only search until a space is found in the string so..
i'm doing good (doesn't work)
i'mdoinggood (works!)

so my advice would be..

1) code your own strstr() function to fix this. (effective)
2) code a string preprocessing function to erase spaces. (not so effective but should work in most cases).

ROCKaMIC

EDIT: sorry.. you can forget the advice, i did it because i recoded everything in C to save compilation time and i used scanf().. nevermind then :P

ROCKaMIC: Thank-you for your advice

Indeed, the problem was not with strstr(), but with the fact that you were only reading in until a space (which from your edit I presume you figured out).