Thread: change characters entered from user to all uppercase

i made a program in Visual C++ and then tried to run it on Dev C++, and i used the command "toupper" and when i tried to run it on Dev, it wouldn't compile, here's the sample code....

if(line[i]!=' ') wadptr[cnt]->word[i]=toupper(line[i]);else break;

i need something to replace the "toupper"...

Thanks!!

I found this in ctype.h in my MSVC++6.0 include dir
#define _toupper(_c) ( (_c)-'a'+'A' )
I'm don't feel like analysing the precompiler directives to find out when this is compiled, but this is a example of extreme stupidity. So check whether your toupper function is working well.

Code:

char my_toupper(char c){
    if('a'<=c && c<='z')
        return c-'a'+'A';
    return c;
}
//Or as macro if you prefer:
#define my_toupper(c) ( ('a'<=(c) && (c)<='z') ? ((c)-'a'+'A') : (c) )

like quzah said, make sure you include the correct header file.

Code:

#include <ctype.h>

Originally Posted by Xipher

shouldn't that be #include<ctype>, since the .h is droped now.

No. It should either be <ctype.h> or <cctype>. Both are standard, the first one is deprecated for C++, the second one is preferred for C++.

This is the code I used in a previous program in order to convert to upper case:
input is the message stored in a char array

Code:

for(int i=0; i<(strlen(input)); i++) {
    input[i] = toupper(input[i]);              // convert the input to UPPER CASE
}

The only header I had to include was iostream