Why won't this change string to int?

[Jenica]

comm keeps giving me 0, and I don't know why...

int main()
{

 int memory[64];
 string command, s1, input, s2, space;
 int eight, num1, num2, temp, comm;

 int valid_location(int);
 void get_numbers(string, string&, string&);

 space = " ";

 for (int i = 0; i < 64; i++)
        {
          memory[i] = -999;
        }

 cout << endl << "Command: ";
 getline(cin,input);

 command = input.substr(0,1);
 comm = atoi(command.c_str());

 cout << command << endl;
 cout << comm;

 return 0;
}

Thanks!

[hk_mp5kpdw]

comm keeps giving me 0, and I don't know why...

What input are you trying to enter at your "Command:" prompt?

int main()
{

 int memory[64];
 string command, s1, input, s2, space;
 int eight, num1, num2, temp, comm;

 
 // These two lines should not be here, they belong outside of the main function
 int valid_location(int);
 void get_numbers(string, string&, string&);

 space = " ";

 for (int i = 0; i < 64; i++)
        {
          memory[i] = -999;
        }

 cout << endl << "Command: ";
 getline(cin,input);

 command = input.substr(0,1);
 comm = atoi(command.c_str());

 cout << command << endl;
 cout << comm;

 return 0;
}

[pablo615]

If the 1st char of the command is not a number, atoi will not convert it and will simply return 0.

You need to validate the input before you give it to atoi

PK

[Hunter2]

int valid_location(int);
void get_numbers(string, string&, string&);

I'm surprised you're not getting errors here. Function prototypes have to be declared outside of main().

Also, if you declare command as a char, you can also replace input.substr(0,1) with input[0]. Then, instead of using atoi(), you just need to do:

char command;
command = input[0];
comm = command - '0';

Other than that, assuming that your input has a digit as the first character and you have your parameters in substr() correct, I don't see anything wrong (except for the function prototypes that are stuck in there out of nowhere).