Thread: switch statement inside a do while

The exit condition of my do while loop is while the char variable choice is not equal to q or to Q...however when i enter q it displays the default case in the switch and doesnt exit the loop...here's the 1st half of the loop...

Code:

    {
        cout << "Benevolent Order of Programmers Report\n"
             << "a. Display by name\t     b. Display by title\n"
             << "c. Display by bopname\t  d. Display by Preference\n"
             << "q. Quit\n";
        cout << "Your choice? ";
        cin  >> choice;
        cout << "\n";
        switch(choice)
        {
            case 'A':
            case 'a':  cout << s_known[0].fullname << endl
                            << s_known[1].fullname << endl
                            << s_known[2].fullname << endl;
                       cout << "\n";
                            break;
            case 'B':
            case 'b':  cout << s_known[0].title << endl
                            << s_known[1].title << endl
                            << s_known[2].title << endl;
                       cout << "\n";
                            break;

Code:

 default:   cout << "You entered an invalid option!\n";
                       break;
        }

    } while (choice != 'q' || choice != 'Q');
    cout << "BYE!\n";

And here's the very end of it right after my last case in the switch...the "BYE" is never reached, any idea what's going wrong? Thanks for all the help everyone -Chap

Code:

bool Continue = true;
while(Continue)
{
   //menu
   switch (choice)
   {
	  ....
	  case 'Q':
	  case 'q':
		cout << "BYE" << endl;
		Continue = false;
		break;
	  default:
		cout << "invalid option" << endl;
   }
}

thanks for the help....I'm just curious why it isn't exiting out the way I did it...is it stuck inside the switch statement? That wouldn't make sense though because if the user inputs q right off the bat it should skip the entire loop body, right?

try && instead of || in the while conditional. Since choice can't be 'q' and 'Q' at the same time either choice != 'q' or choice != 'Q' has to be true, so the || will always be true. Whereas the && version will only be true if choice not equal to either 'q' or 'Q'.