Thread: Where are all these errors coming from?

I'm trying to write a program that adds two money amounts in old-style British currency---pounds, shillings, pence---and asks if the user wants to continue. It also adds a pound every 20 shillings, and adds a shilling every 12 pence. (it's an exercise in my book).

Code:

#include <iostream>
using namespace std;

int main()
{
	
		int pnd, shl, pnc;
		int pnd2, shl2, pnc2;
		int totp, tots, totpn;
		char c;
		char ch;

		while (ch != 'n') 
		{
			cout << "Enter two amounts in pounds, shillings, and pence: ";
			cin >> pnd >> c >> shl >> c >> pnc;
			cout << endl;
			cout << "Enter second amount: ";
			cin >> pnd2 >> c >> shl2 >> c >> pnc2;
			cout << endl;

			totp = pnd + pnd2;
			tots = shl + shl2;
			totpn = pnc + pnc2;

			while (!(tots % 20))
			{
				totp += 1;
				tots -= 20;
			}

			while (!(totpn % 12))
			}
				tots += 1;
				totpn -= 12;
			}		

			cout << "Total is " << totp << "." << tots
				 << "." << totpn << endl << endl;
			cout << "Continue (y/n)?";
			cin >> ch;
		} 

		return 0;
}

The problem is it brings up seventeen errors, most of them pertaining to a (or several) missing semicolon. I've looked over the code and I don't see any syntax mistakes. What is wrong with the code?

By the way, I know I might have made a few calculating mistakes (to display the correct result), but I'm going to fix any stuff like that once I rid of these errors.

what line numbers do the errors occur on?

All your errors stem from one backwards bracket. Change the bracket after "while (!(totpn % 12))" to point the other way.

Thanks! I didn't even think to look at the braces.

I have just one more question; my original test expressions for the carrying of pounds and shillings (20 shillings = 1 pound, 12 pounds = 1 shilling) didn't give correct results, so after a bit of trial and error the tests are now just:

Code:

                        while (totpn > 11)
			{
				tots += 1;
				totpn -= 12;
			}
					
			while (tots > 19)
			{
				totp += 1;
				tots -= 20; 
			}

whereas my original tests were in this form:

Code:

while (!(tots % 20))

They didn't produce correct results, and I'm not sure why. "While tots is evenly divisible by 20" is how I read it, so it's hard for me to figure out what the problem is.

Originally Posted by jrahhali

By any chance, would you happen to be using "Object-oriented programming in C++" by robert lafore?

I sure am.

They didn't produce correct results, and I'm not sure why. "While tots is evenly divisible by 20" is how I read it, so it's hard for me to figure out what the problem is.

I think you're error comes from that fact that zero modulus a number is zero, so you get something like:

tots=20
20%20==0 so do while loop, tots-=20 so tots=0
0%0==0 so stay in while loop, tots-=20 so tots=-20

From here on I'm not sure what happens, don't know if every compiler would assess -20%20 as zero or not.