Enter password, hide by "*".

**toysoldier** · 08-12-2004

I write a little program, just want to test getch() function.
When you enter password, they dont display in monitor,
instead of "*". It 's running OK.
But some statements look very stupid,
please give some improvement!
thanks.

PHP Code:


#include <iostream.h>

#include <conio.h>

#include <stdlib.h>



void main()

{

    char m[3]={'t','o','y'};   //to save original password.

    char n[3]={'0','0','0'};  //initialize your entering password.

    cout<<"Please enter 3 bit password: "<<flush;  

    n[0]=getch();            //enter word ,but no display it              

    cout<<"*"<<flush;    //when enter word, display “*”

    n[1]=getch();

    cout<<"*"<<flush;

    n[2]=getch();

    cout<<"*"<<flush;

    if(m[0]==n[0]&&m[1]==n[1]&&m[2]==n[2])   //stupid code!

    {

        cout<<"password correct,welcome!"<<endl; 

    

     }

    else

    {

        cout<<"error."<<endl;

    }



system("pause");    //pause running window.

return;



}

**prog-bman** · 08-12-2004

it looks ok to me besides the

Code:

void main()

main should always return a int

Code:

int main(void)
{
  //code
  return 0;
}

**toysoldier** · 08-12-2004

@ prog-bman :
OH, it's a tip "int instead of void" or rule ?

How about this statement:

if(m[0]==n[0]&&m[1]==n[1]&&m[2]==n[2]) //stupid code!

Thanks.

**bennyandthejets** · 08-12-2004

That looks fine.

**Princeton** · 08-12-2004

>>OH, it's a tip "int instead of void" or rule ?
It is a rule. The C++ standard requires main to return an integer except in very specialized implementations where it imposes no restrictions. The general rule of thumb is that if you do not know whether or not you are using such an implementation, you are not and thus the relaxed rules do not apply to you. As such, instead of saying that every time somebody uses void as the return type for main, most helpful souls will simply tell you that returning void from main is illegal or wrong or evil or something similar for the sake of brevity.

**toysoldier** · 08-12-2004

@ Princeton :
Thanks,
I think I have learning a lot of valuable knowledge after entered this great forum.
Thanks every friend !

**elad** · 08-12-2004

You will probably learn about control loops in the near future. They will provide you with the techniques to "clean up" the sections of the code that you felt uncomfortable with.

**Zach L.** · 08-12-2004

One other thing.
<iostream.h> is no longer standard, use <iostream> and the std namespace (putting 'using namespace std;' after your includes is the easiest to start with).
<stdlib.h> is standard C, but it is good to get in the habbit of using <cstdlib> in C++ along with the namespace.
Just be aware that <conio.h> is a non-standard header and you may or may not find it if you change compilers.

Code:

#include <iostream>
#include <conio.h>
#include <cstdlib> 

using namespace std;

**Hunter2** · 08-12-2004

>>if(m[0]==n[0]&&m[1]==n[1]&&m[2]==n[2]) //stupid code!
An easier way to do this would be:

Code:

char m[4]="toy";   //4th character is '\0' (null). 
char n[4]="000";  //same as above.

(...)

if(strcmp(m, n) == 0)   //compare the strings m and n
{...}
else
{...}

**OR**

char m[3] = {'t','o','y'};
char n[3] = {'0','0','0'};

(...)

if(memcmp(m, n, 3) == 0)   //compare 3 elements of m and n
{...}
else
{...}

Hope this helps!

**abyssphobia** · 08-12-2004

ok your code corrected will be like this:

#include <iostream>
#include <cstdlib>
#include<conio.h>

using namespace std;

int main()
{

char m[3]={'t','o','y'}; //to save original password.

char n[3]={'0','0','0'}; //initialize your entering password.
cout<<"\n"
cout<<"\nPlease enter 3 bit password: "<<flush;

n[0]=getch(); //enter word ,but no display it

cout<<"*"<<flush; //when enter word, display “*”

n[1]=getch();

cout<<"*"<<flush;
n[2]=getch();
cout<<"*"<<flush;
if(m[0]==n[0]&&m[1]==n[1]&&m[2]==n[2]) //stupid code!
{
cout<<"password correct,welcome!"<<endl;

}
else
{
cout<<"error."<<endl;
}

system("pause"); //pause running window.
return 0;

}

but I ran it,mmm the pasword is toy!!!!

**linuxdude** · 08-12-2004

just to let you know that isn't a 3 bit password

**Hunter2** · 08-12-2004

I like the original code better. Slightly less standard, but it's code-tagged (Actually PHP tagged, but that's better than nothing), and the spacing is more intuitive. Abyssphobia, use code tags!

**abyssphobia** · 08-12-2004

yeah it's 4 bit pasword!!! zero is null duh!!mmm sorry a little distraction
mmm code tags?
How?? I read the post but I didnt got it. =(
you know, Im gonna print the post to look it better=)

regards,

Abyss

**C++Child** · 08-12-2004

No its a 3 bit. 0 - 1 - 10 - 11. 11==3.

**linuxdude** · 08-12-2004

what, no.

Code:

#include <limits.h>
number_of_bits=CHAR_BIT*(strlen(m));
number_of_bits+=CHAR_BIT;

plust your code doesn't have enough room for a terminating '\0'(if I enter three characters)

Thread: Enter password, hide by "*".

Thread Tools

Search Thread

Display

Enter password, hide by "*".

Similar Threads

Need Help With a BlackJack Program in C

To enter password without displaying it in a password checking program

[Q]Hide Password

hi need help with credit limit program

terminate 0 - PLEASE HELP