Thread: Ok take a look at this program

whats your opinion ??? please run it !!!! to see what it does.

# include <iostream.h>
# include <stdlib.h>


double on,lb,gramo,kilo,gina,total;



void main()

{
char no;
do{
cout <<" \n Put Ur Weight In thE sYsteM EnglIsH ";
cout<<"\n ";
cout<<"\n libras: ";
cin>>lb;
cout<<" onzas: ";
cin>>on;

kilo= lb/ 2.2046;
gramo= on/.0352736;
gina = gramo/1000;
total = kilo+gina;

cout<<"\ntu el peso en kilos es "<<kilo;
cout<<"\nY en gramos es "<<gramo;
cout<<"\n\n Pero en Total Tu peso es "<<total;
cout<<" \n\n deseea otra operacion??s/n ";
cin>>no;
cout<<"\n";

}while(no!='n');
}

if u found a improvement please send it , I be glad to see. it was mi final exam , so easy as you see.

Originally Posted by abyssphobia

whats your opinion ??? please run it !!!! to see what it does.

# include <iostream.h>
# include <stdlib.h>


double on,lb,gramo,kilo,gina,total;



void main()

{
char no;
do{
cout <<" \n Put Ur Weight In thE sYsteM EnglIsH ";
cout<<"\n ";
cout<<"\n libras: ";
cin>>lb;
cout<<" onzas: ";
cin>>on;

kilo= lb/ 2.2046;
gramo= on/.0352736;
gina = gramo/1000;
total = kilo+gina;

cout<<"\ntu el peso en kilos es "<<kilo;
cout<<"\nY en gramos es "<<gramo;
cout<<"\n\n Pero en Total Tu peso es "<<total;
cout<<" \n\n deseea otra operacion??s/n ";
cin>>no;
cout<<"\n";

}while(no!='n');
}

>># include <iostream.h>
>># include <stdlib.h>
Neither of these are legal C++ anymore. They may work on modern compilers and will work on older compilers, but keep in mind that you are working with pre-standard C++.

>>double on,lb,gramo,kilo,gina,total;
There is no reason to use global variables when the only function in your program is main.

>>void main()
This has never been correct. main returns an integer.

Here is the same code modernized, corrected, and with consistent formatting.

Code:

#include <cstdlib>
#include <iostream>

using namespace std;

int main() 
{
  double on, lb, gramo, kilo, gina, total;
  char no;

  do{
    cout << " \n Put Ur Weight In thE sYsteM EnglIsH ";
    cout << "\n "; 
    cout << "\n libras: ";
    cin >> lb;
    cout << " onzas: ";
    cin >> on;

    kilo = lb / 2.2046;
    gramo = on / .0352736;
    gina = gramo / 1000;
    total = kilo + gina;

    cout << "\ntu el peso en kilos es " << kilo;
    cout << "\nY en gramos es " << gramo;
    cout << "\n\n Pero en Total Tu peso es " << total;
    cout << " \n\n deseea otra operacion??s/n "; 
    cin >> no;
    cout << "\n";
  }while (no != 'n');

  return 0;
}

Thx,well Im using a older compiler,Princeton Thx a lot, Ill take in mind. =)

Ok I ran the code like u put princeton, and it works, ok its not a compilers issue , it the way my teacher theach me;So thank you so much. Now I know a better way to use that, Cuz Im a begginer as you see.

no offense, but i'm kindof surprised your teacher is teaching you global variables this early on. there is always a way around using them, except for very very rare cases. i've seen teachers teach void main, as though it should, i see some of their points in doing so in the beginning..