this.feet = 0;
this.inches = 0;
this.MTF = 3.280833F; //etc
Again, a good example on missusing the this pointer. I've seen it in some other threads too - I think once people get the taste of this, they use it without a reason...
The same applies for inicialization lists. A bad example:
Code:
class Dummy
{
private:
int i1, i2, i3, i4, i5, i6, i7;
public:
Dummy( int i1_in, int i2_in, int i2_in, int i4_in, int i5_in, int i6_in, int i7_in ) : i1(i1_in), i2(i2_in), i3(i3_in), i4(i4_in), i5(i5_in), i6(i6_in), i7(i7_in)
//.
};
Just one more thought on inicialization lists:
- for built-in types it should be used only to initialize constants and references (there's no other way unless declared as static)
- the real benefit of initialization lists is initialization of user defined data members (classes and structs), as instead of construction and a call to "operator =" only the copy constructor is called
One more thing: the order in the inicialization lists should respect the declaration order, else interesting things might occur!