Thread: Why doesnt this work

Okay again a very basic question, I followed the tutorial step by step and it does not want to work. It executes fine but it will not say the passwords match

<code>
#include <iostream.h>

void main()
{
//declerations
char userName[24] ="";
char pw[8]="";
char pw2[8]="";

cout << "Enter a user ID: ";
cin >> userName;
cout << "Enter a password: ";
cin >> pw;
cout << "";
cout << "Re-Enter your password: ";
cin >> pw2;

if (pw==pw2)
{
cout<<"Your passwords match"<<endl;
}
else
{
cout<<"Your passwords do not match"<<endl;
}

}

</code>

It takes two seconds to read you will understand what I mean

><code>
Square brackets, not angle brackets.

>void main()
int main(). Even if you're using a compiler that refuses to support the new headers and namespaces, void main is still wrong.

>if (pw==pw2)
pw and pw2 are pointers. This isn't doing what you want. Try including <string.h> (preferably <cstring>) and use strcmp:

Code:

if ( strcmp ( pw, pw2 ) == 0 )

>It takes two seconds to read
That depends on how well one reads code with a zero indention.

I thought the <string.h> would fix it, but it is still returning the passwords don't match

>but it is still returning the passwords don't match
Then you aren't doing it right. This works fine:

Code:

#include <iostream> 
#include <cstring>

using namespace std;

int main() 
{
  //declerations
  char userName[24] ="";
  char pw[8]="";
  char pw2[8]="";

  cout << "Enter a user ID: ";
  cin >> userName;
  cout << "Enter a password: ";
  cin >> pw;
  cout << "";
  cout << "Re-Enter your password: ";
  cin >> pw2;

  if ( strcmp ( pw, pw2 ) == 0 )
  { 
    cout<<"Your passwords match"<<endl;
  }
  else
  {
    cout<<"Your passwords do not match"<<endl;
  }
}

The only changes I made were strcmp, including <cstring>, making main return int, and using the new headers because the compiler I'm using right now complains if I don't.