Thread: Wordlist problem with code!!

Obviously fro the source you can see i have no idea what i'm doing, but i hope you get the idea.

Code:

#include <fstream.h>
#include <iostream.h>

int main()
{
    ifstream infile("input.txt");
    ofstream outfile("wordlist.txt");

    char word;
    
    while (infile >> word)
      {
	 if (word == ' ') word = '\n';
	 outfile << word;
	 infile.get(word);
	 outfile.put(word);
      }

   return 0;
}

The input.txt looks like this

Code:

ad am an as at ax cat dog pig horse animal

I'm trying to make the out put file look like this..

Code:

ad
am 
an 
as 
at 
ax 
cat 
dog 
pig 
horse 
animal
"you get the idea...."

How do i accomplish this????

Code:

while (infile >> word)  // you input a character
{
    if (word == ' ') word = '\n';
    outfile << word;    // you output the character
    infile.get(word);   // you now attempt to input multiple 
                        //    characters into a single char
    outfile.put(word);  // get rid of these two lines
}

>while (!infile.eof())
The eof member function is not meant to be used as a loop condition. This is wrong.

>word = new char;
Why use dynamic allocation for a single char?

>infile.close();
>outfile.close();
These are closed automatically in the destructor.

Code:

#include <cstdlib>
#include <fstream>
#include <string>

using namespace std;

int main()
{
  ifstream in ( "input.txt" );
  ofstream out ( "wordlist.txt" );

  if ( !in.is_open() || !out.is_open() )
    return EXIT_FAILURE;
  string word;
  while ( in>> word )
    out<< word <<'\n';
}

hi prelude, i am also watching this topic. ...your solution is compact and straightforward.

one small question on your code. it is a very silly question i agree .........why you are writing return EXIT_FAILURE;
is there anything like EXIT_SUCCESS ? ? the naming is inappropriate here. Bcoz if none of the condition satisfied then really it will exit ... so it should have been EXIT_SUCCESS.(if it exist at all)

however, dont you think the naming is inappropriate? of course i understand i have to obey the grammer of the language.

>why you are writing return EXIT_FAILURE
Because if one of the files fails to open, the program should terminate, preferrably with an error.

>is there anything like EXIT_SUCCESS ?
Yes, though I didn't use it here because the appropriate value is returned automagically when the closing brace of main is reached.

>dont you think the naming is inappropriate?
No. Using EXIT_SUCCESS for unsuccessful termination doesn't make sense, so I used EXIT_FAILURE because if one of the files fails to open, the program can't do what it was written to do.

"....EXIT_FAILUREbecause if one of the files fails to open..."

hmmm...ok. it was a misunderstanding of the phrase with the SUCCESS.


however, i used to write exit(0) if it fails.

thanks for the clarification

>however, i used to write exit(0) if it fails.
That's the same thing as return 0.