Thread: file problem

I have this problem:

Code:

#include <string>
#include <fstream>
#include <iostream>
using namespace std;

int main()
{
	string s;
	cout<<"Enter file name: ";
	getline(cin,s);
	ofstream File(s.c_str());
	if(!File)
	{
		cout<<"Error openning file!"<<endl;
		return 1;
	}
	for(;;)
	{
		cout<<"Enter new sentence: ";
		getline(cin,s);
		File<<s;
		File<<'\n';
		cout<<"Enter 0 for exit or something else to continue: ";
		getline(cin,s);
		if(s=="0")
			break;
		cin.clear();
		cin.ignore(1000);
	}
	return 0;
}

but his won't stop. How can I fix it?

One possible solution is to call good old C for help
This code is working fine:

Code:

#include <string>
#include <fstream>
#include <iostream>
#include <cstdio>
using namespace std;

int main()
{
	string s;
	cout<<"Enter file name: ";
	getline(cin,s);
	ofstream File(s.c_str());
	if(!File)
	{
		cout<<"Error openning file!"<<endl;
		return 1;
	}
	int end;
	for(;;)
	{
		cout<<"Enter new sentence: ";
		getline(cin,s);
		File<<s;
		File<<'\n';
		printf("Enter 0 to exit: ");
		scanf("%d",&end);
		if(!end)
			break;
		fflush(stdin);
		
	}
	return 0;
}

Until now I've always used cstdio when dealing with files , but today I decided to learn how C++ handles files and at the very first begining I get problem.

Thanks

fflush(stdin);

instead of a for loop with terminal sequence creating an endless loop you could try a while loop like this:

Code:

while(s != "0")
{
  cout<<"Enter new sentence.  Enter 0 to exit: ";
  getline(cin,s);
  File<<s;
  File<<'\n';
}

Your original code works fine if you put "0" the first time through the loop. If you don't, then the cin.ignore(1000) is screwing you up. I don't see any reason to ignore anything there, because you will have gotten everything in the input stream into the string s already.

If you are trying to let the user hit "enter" again before asking for a sentence again, then use:

cin.ignore(1000, '\n');

or

cin.ignore(std::numeric_limits<int>::max(), '\n');