Logical error in push node...

[girlzone]

This is the definition of a method in the class Stack. It is supposed to push a new node in the stack (which is represented as a linked list).Why is this logically wrong although it is error free??

Error_code Stack :: push_stack( Stack_entry item)
{
Node new_top(item,top_node);
top_node=&new_top;
Return success;
}

thank you :)

[Sebastiani]

As soon as the function exits, 'new_top' goes out of scope and is destroyed. Use dynamic allocation (don't forget to delete each node when done).

Error_code Stack :: push_stack( Stack_entry item)
{
Node * new_top = new Node(item,top_node);
top_node = new_top;
Return success;
}