Thread: Storing strings in 2d char arrays problem

I am trying to store strings in a 2d array to seperate the text that is between certain charators. It outputs the strings, but with other charactors what i don't wan't also. Can anyone tell me how to correct this? Thankyou for your time.

Code:

#include <iostream.h>

int main()
{
char string[5][8];
char words[30] = "TEXT+TEST+TEXT+TEXT";
int x,y;


for (y = 0; y < 4; y++)
    {
    for (x = 0; x < 4; x++)
        {
        if (words [x] == '+')
            continue;
            
        string[y][x] = words[x];
        }
    }

for (x = 0; x < 4; x++)
    {
    cout << string[x] <<endl;
    }

cin.get();
return 0;
}

1. You never terminate the strings with the null character. For each string in your array, you should add '\0' to the end of the string, or initialize them all to all 0 before your start.

2. I'm not sure you program works the way you want after you do this (TEST never gets output), but you can worry about that next.

3. I'd recommend using the standard C++ library headers. That means <iostream> instead of <iostream.h>. If you do you will have to deal with the std namespace, but simply putting using namepsace std; once under your #includes should be fine for now while you have small programs.

I wan't to store words in an array sort of like the array below. Everytime i try it it gives me weird results in the output(weird charactors in the output). The code below works fine for me, but the words are already in the array, I want to get words from a string and store them in the array though.

Code:

#include <iostream>

using namespace std;

int main()
{
char array[7][10] = {"Sun","Mon","Tues","Wed","Thurs","Fri","Sat"};
int x;

for (x=0;x<7;x++)
    {
    cout <<array[x];        
    cout <<endl;
    }
cin.get();
return 0;
}

the process you are describing is commonly called parsing. If you have a specific char you wish to parse on, say the + sign in your example, or the space char, or any other char or combination of char for that matter, then you can use the strtok() function for C++ strings or the find() function for STL strings to determine where each word in the string starts and stops and then add them to the array. Alternatively, you can write your own parsing function by reading the string char by char looking for the termination/start char and storing each char in an array, null terminating the array, and then adding the C string the array of C strings.