what's wrong

**gamer** · 10-16-2003

this is my code

Code:

#include <iostream.h>
#include <stdlib.h>

int main()
{
 int regio;

 cout <<" (c) copyright www.gratischeck.web1000.com \n";
 cout <<"beantwoord de volgende vragen\n";
 cout <<"belt uw in de regio of buiten de regio het meeste\n";
 cout <<"regio : 1  buiten regio : 2 \n"  ;
 cin>>regio;
 goto callreg;
 system("pause");

 int callreg();
{
if (regio = 1)
{
cout <<"uw belt in de regio het meest\n";
goto pause;
}
if (regio = 2) ;
{
cout <<"uw belt het meeste niet in uw regio\n";
goto pause;
}
}

int pause()
{
system("pause") ;
}

i get these error messages

c:\docume~1\php---~1\mydocu~1\tel\untitl~1.cpp: In function `int main()':
c:\docume~1\php---~1\mydocu~1\tel\untitl~1.cpp:31: parse error before `{'
c:\docume~1\php---~1\mydocu~1\tel\untitl~1.cpp:21: label `pause' used but not defined
c:\docume~1\php---~1\mydocu~1\tel\untitl~1.cpp:13: label `callreg' used but not defined

i can't find the problem

**Fahrenheit** · 10-16-2003

Uh, you can't call functions with goto. Instead of "goto callreg" you would do "callreg()"

**gamer** · 10-16-2003

i try'd to change

goto pause;

and changed in to

goto pause();

it ditn't work

and of course

changing it to

pause()

isn't right to

**Fahrenheit** · 10-16-2003

Yes it is.

EDIT: Try putting int pause (); and int callreg() ; at the top of your program. You might also want to close the bracket on main() and remove the semicolon after callreg() and the if statement in callreg()

**jlou** · 10-16-2003

There are actually lots of little problems with your code.

You can't define a function inside main(). Move the callreg function outside and below main.
You need a function prototype above main() for your two functions - callreg and pause. For example:

int callreg();
Your if statements are not correct. You should use:

if (regio == 1)

Otherwise your are assigning 1 to regio instead of comparing 1 to regio.
You are using old and deprecated header files. Change your includes to:

#include <iostream>
#include <cstdlib>
using namepsace std;
And finally, change your function calls to:

callreg();

and

pause();

**gamer** · 10-16-2003

i have changed my code

Code:

#include <iostream>
#include <stdlib.h>

int pause()
{
system("pause") ;
}

int hello();
{
if (regio == 1)
{
cout <<"uw belt in de regio het meest\n";
goto pause;
}
if (regio == 2) ;
{
cout <<"uw belt het meeste niet in uw regio\n";
goto pause;
}
}

int main()
{
 int regio;
 cout <<" (c) copyright www.gratischeck.web1000.com \n";
 cout <<"beantwoord de volgende vragen\n";
 cout <<"belt uw in de regio of buiten de regio het meeste\n";
 cout <<"regio : 1  buiten regio : 2 \n"  ;
 cin>>regio ;
 goto hello();
 system("pause");
 }

iam trying to get the last 3 bugs out

c:\docume~1\php---~1\my documents\tel\untitled2.cpp:10: parse error before `{'
c:\docume~1\php---~1\my documents\tel\untitled2.cpp: In function `int main()':
c:\docume~1\php---~1\my documents\tel\untitled2.cpp:31: parse error before `('

**Fahrenheit** · 10-16-2003

Are you not listening at all?

Remove every goto you have in there.

Code:

int hello();

Right there, you need to remove the semicolon.

Code:

if (regio == 2) ;

Right there, you need to remove the semicolon.

Code:

goto pause;

change this to pause(); No goto. Same with

Code:

goto hello();

That needs to be just hello() ;

**jlou** · 10-16-2003

I'm wondering, are you trying to implement goto, or are you trying to implement a function. They are of course two very different things.

If you are trying to implement a function (which I believe is generally accepted as being infinitely better than using goto), then follow w00tsoft's advice.

In addition, when calling a function you must understand that the variables that you declare and use in one function (like main()) are not available to use in another function (like hello()). In your code, you declare and use regio in main(), then use it in hello(). The problem is that hello() doesn't know about this variable.

To fix it you will have to pass the variable into your function.

And finally, good job on changing to <iostream> instead of <iostream.h>, but you didn't follow my advice completely, and so your code will still not work. You left out the using namespace std; part under the includes.

**gamer** · 10-16-2003

i dit it but
in this part is stil 1 error

Code:

int hello();
{
if (regio == 1)
{

it says before the first {

what iam meanning to

is

- yes
yes or no -yes
- no - next - yes or no
-no

**jlou** · 10-16-2003

Originally posted by w00tsoft
Are you not listening at all?

Code:

int hello();

Right there, you need to remove the semicolon.

Uhh, you didn't remove the semicolon (you know, the ';' character that you put after ()).

You should only put the semicolon if it is a prototype (meaning you aren't defining the function).

If you are defining the function (meaning you put { ...code... }), then you don't want the semicolon.

Thread: what's wrong

Thread Tools

Search Thread

Display

what's wrong

re:

Similar Threads

Problem with input choice... Somethings wrong... really wrong....

Debugging-Looking in the wrong places

Confused: What is wrong with void??

God

Whats wrong?