Thread: String Length function

Hi everyone, I have been learning about strings and successfully wrote my first string program which counts the characters in a given sentence. The problem that I ran into was that I wanted the program to count a string of characters that was entered by the user (no matter what it was)
e.g.
My name is Glenn
output: 16 (including spaces)

This is the program I was able to successfully run

Code:

#include<iostream.h>
#include<cstring>

int main()
{
char *string_a= "This is a test";

cout<<"The length of \""<<string_a<<"\"is "<<strlen (string_a)<<endl;

return 0;
}

This is the program that I am trying to write so that it returns the number of characters input by the user

Code:

#include<iostream.h>
#include<cstring>

int main()
{
char *string;

cout<<"What is your string";
cin>>string;

cout<<" The length of "<<string<<" is " << strlen (string)<<endl;

return 0;
}

I thought that the program was written correctly because it returns no (compiling) error but when it compiles Visual C returns an error and closes my program out.


Can someone please poing me in the right direction....Should I start over??

Thank you very much

Sorry, I didn't notice that you really want the input with the spaces. Here are the two pieces of code above corrected to accept the entire line.

Preferred using standard string:

Code:

#include<iostream>
#include<string>

int main()
{
    std::string string_a;

    std::cout<<"What is your string: ";
    std::getline(std::cin, string_a);

    std::cout<<" The length of \""<<string_a<<"\" is " << string_a.length()<<std::endl;

    return 0;
}

And using c-style strings:

Code:

#include<iostream>
#include<cstring>

int main()
{
    char string_a&#091;100&#093;;

    std::cout<<"What is your string: ";
    std::cin.getline(string_a, 100);

    std::cout<<" The length of \""<<string_a<<"\" is " << strlen (string_a)<<std::endl;

    return 0;
}

Hi everyone, I just wanted to say thanks for the help. I was able to clean up my code and run it successfully.

Thanks