Agh, what's wrong with this function?

**Grins2Pain** · 09-28-2003

Can anyone spot anything glaringly wrong with this function? It's supposed to change one of the bit flags in a int with a pass-by referance. If it matters, the int in question is a dynamically allocated pointer within a class.

For some reason it isn't changing the target. I could go nuts here. If this isn't enough info I could post the whole program, but I don't THINK that should be necessary.

Code:

void body::flagset( int &target, const int bit, const char*op_type )

{

	if (op_type == "lower")

		target = target & (int)(!(pow(2, bit - 1)));
	
	else if (op_type == "raise")

		target = target | (int)(pow(2, bit - 1));
	
}

**-=SoKrA=-** · 09-28-2003

You can't compare c-style strings like that. This should work, assuming the the way you change the bit flags works.

Code:

void body::flagset( int &target, const int bit, const char*op_type )

{

	if (!strcmp(op_type, "lower"))

		target = target & (int)(!(pow(2, bit - 1)));
	
	else if (!strcmp(op_type, "raise"))

		target = target | (int)(pow(2, bit - 1));
	
}

EDIT: You should #include <cstring> if you haven't done so already and using namespace std.

Thread: Agh, what's wrong with this function?

Thread Tools

Search Thread

Display

Agh, what's wrong with this function?

Similar Threads

Undefined Reference Compiling Error

Game Pointer Trouble?

airport Log program using 3D linked List : problem reading from file

structure vs class

Contest Results - May 27, 2002