Thread: Sorting Strings

I only noticed the swap at first (which is a big problem).

The duplication is because the swap function is still broken.

They both DO work fine, but perhaps you put the function definition in the wrong place. This was my working code:

Code:

#include <iostream>
#include <cstdlib>
#include <cstdio>

using namespace std;

inline void swap(int &a, int &b){
   int temp = a;
   a = b;
   b = temp;
}

#define INDEX 5

void bubble_srt(int a[], int n);

int main(void)
{
     
     int array[INDEX] = {12, 8, 35, 92, 19}; //Altered the numbers...

     cout<<"Before sorting:"<< endl;
     for(int i=0; i<INDEX; i++)
		cout<< array[i]<< endl;

     bubble_srt(array, INDEX);

     cout<<"After the sort:"<< endl;
     for(int i=0; i<INDEX; i++)
		cout<< array[i]<< endl;

}

void bubble_srt(int a[], int n)
{
	int i, j;
	for (i=0; i<n-2; i++) {
		for (j=0; j<n-1-i; j++){
			if (a[j+1] < a[j])
				swap(a[j],a[j+1]);
		}
	}
}

Just out of curiousity...why don't you just use the std::sort( ) function (from <algorithm>) to do this like I showed in a previous post?

Is that really more efficent, though? It still requires three passes through an ALU, and none of the operations can happen in parallel.

Well, it's (very slightly) more memory efficient. I dunno, I just don't like decalring variables that I don't have to. I threw it in there because I thought it was kind of a cool tidbit...and I like being crafty with booleans. As far as speed effeciency, yeah there probably is no noticable difference, although I've never tested it.

Standard C++ headers do not have .h on the end. If I wanted to use the C standard header stdlib.h, typically C++ headers drop the .h and add a 'c' to the front, thus <cstdlib>.

Indeed, none of the C++ standard headers include a .h; for example, #include <iostream> is standard, #include <iostream.h> is NOT standard, and not guaranteed to work.

Code:

#include <iostream>
#include <vector>
#include <algorithm>

using namespace std;

int main() {

        vector<int> numbers;
        int temp;

        cout <<"Enter five numbers to sort: " <<endl;

        for( int iter = 1; iter <= 5; iter++ ) {
                cout <<"#" <<iter <<": ";

                cin >>temp;
                numbers.push_back( temp );
        }

        sort( numbers.begin(), numbers.end() );

        cout <<"\nSorted list: " <<endl;

        for( int index = 0; index < numbers.size(); index++ ) 
                cout <<numbers[index] <<endl;

}

That's the C++ solution to your problem. If you don't know what vectors are or how to use them, I strongly suggest learning.