Thread: Using strcmp with enumerations.

Just curious as to how this would work. This is what I have come up with so far.

Code:

#include <iostream>
using namespace std;

int main()
{
int dailysum,costofUpkeep,cash_made,weeklysum;
char timecheck[10];

cout <<"How often would you like to check your machines?" <<endl;
cin.getline(timecheck,10)
enum time {"daily","weekly","monthly","yearly"}
    switch((!strcmp(time,timecheck))
        {
        case 0:
                dailysum=costofUpkeep-cash_made;
                cout <<dailysum;
                break;
        case 1: 
                weeklysum = (cash_made * 7)-costofUpkeep;
                cout <<weeklysum;
        }
}

Can't get this to work. THere are only 4 errors:
parse, syntax, and At Global

enum time {"daily","weekly","monthly","yearly"}

Look at the following code--it might prove enlightening:

Code:

#include<iostream>
using namespace std;

int main()
{
	enum Weekday{Mon, Tues, Wed, Thurs, Fri, Sat, Sun};

	Weekday today = Mon;
	cout<<today<<endl;

	today = Tues;
	cout<<today<<endl;

	return 0;
}

Code:

#include <iostream>
using namespace std;

int main()
{
	enum Weekday{Mon=10, Tues=Mon+2, Wed=Tues+2, 
		Thurs=Wed+2, Fri=Thurs+2, Sat=Fri+2, Sun=Sat+2};

	Weekday today = Wed;
	cout<<today<<endl;

	return 0;
}

This is hard to explain. 7stud I am not trying to make an enumeration, I can do that. What I am trying to do is make an enumeration based on user input. The reason I put daily,weekly, monthy etc.... in "" is becuase that is what the user will have to type in. They will be asked how they want to calculate something. Either by day,week,month,year. I didn't want a boring options list so I let the user type in what they wanted. Now, depending on what they typed, wether it be day,week,month,year it would go do a certain part and calculate a formula.......if that makes any sense.

>What I am trying to do is make an enumeration based on user input.
You're trying to solve the wrong problem. Really, you are.

>I didn't want a boring options list so I let the user type in what they wanted.
Bad idea. Options are very predictable, users are quite the opposite. It's easier and simpler to parse options 1, 2, and 3 as opposed to trying to parse the gobbledygook users feel the need to give you.

>Now, depending on what they typed, it would go do a certain part and calculate a formula
You can and should use either some if statements, or a data structure:

Code:

getline(cin, input);

if (input == "daily")
    ...
else if (input == "weekly")
    ...
else if (input == "monthly")
    ...
else if (input == "yearly")
    ...
else
    // Invalid input

or

Code:

getline(cin, input);

if (mymap.find(input) != mymap.end())
    mymap[input]();

Often the simplest seeming solution is far from simple. Dig a bit and you can find the more elegant ones.

Well after toying with it forever this is what I have come up with:

Code:

//Machine Tracking beta(version 1.0)

#include <iostream>
using namespace std;

class Machines
    {
    public:
        char Machine_income(char timecheck,int cash_made);
        int Machine_upKeepCost();
        int Machine_profit();
        int Machine_GetType();
        char Machine_GetLocation();
    private:
        char Machine_type;
        char Machine_location;
    };
XXXint Machines::Machine_income(char timecheck,int cash_made)//,int UpkeepCost)
    {
     int daily_average,weekly_average,monthly_average,yearly_average,NumberofDays;
     
      //Change this to an numeration
        if (!strcmp("daily",timecheck))
               {
                cout <<"In one day the machine made: " <<cash_made <<endl;
                cout <<"How many days would you like to calculate?" <<endl;
                cout <<"Please note: if the amount of days you want to calculate is over 6";
                cout <<" just use the weekly calculations." <<endl;
                cin >>NumberofDays;
                daily_average = (NumberofDays * cash_made);//-UpkeepCost;
                cout <<"In " <<NumberofDays <<"the machine made: " <<daily_average;
               }
                if (!strcmp("weekly",timecheck))
                     {
                     weekly_average = (cash_made * 7);//-UpkeepCost;
                     cout <<weekly_average <<endl;
                     }
                     if (!strcmp("monthly",timecheck))
                          {
                           monthly_average = (cash_made * 30);//-UpkeepCost;
                           cout <<monthly_average;
                           } 
                           if (!strcmp("yearly",timecheck))
                          {
                           yearly_average = (cash_made * 30);//-UpkeepCost;
                           cout <<yearly_average;
                           }                                       
     
     }
     
int main()
    {
        char timecheck[10];
        int cash_made;
        
        Machines p;
        cout <<"To calculate the income produced by your machine(s)";
        cout <<" please select how often you will check them." <<endl;
        cin.getline(timecheck,20);
        cout <<"How much money did it make in that amount of time?" <<endl;
        cin >>cash_made;
        //cout <<"How much does it cost to fill up all of your machines?" <<endl;
        //cin >>UpkeepCost;
        //$230.00 for candy  // $350.00 for toys
        cout <<p.Machine_income(char timecheck,int cash_made);
        system("pause");
    }

This is what I got so far. 9 errors though. I think where the big red x's are is what 1 of the problems may be. I am not sure what I should put there seeing as it is passed a char and an int.

Code:

#include <iostream>
using namespace std;

int main()
{
  int dailysum,costofUpkeep,cash_made,weeklysum;
  char timecheck[10];
  cout <<"How often would you like to check your machines?" <<endl;
  cin.getline(timecheck,10);
  enum time {daily,weekly,monthly,yearly};
  switch((!strcmp(time,timecheck))
  {
        case 0:
                dailysum=costofUpkeep-cash_made;
                cout <<dailysum;
                break;
        case 1: 
                weeklysum = (cash_made * 7)-costofUpkeep;
                cout <<weeklysum;
  }
}

The last error is in your switch statment...

Char timecheck is just one char. use char[] or *char instead. Also your if identination is wrong =)

Code:

        if (!strcmp("weekly",timecheck))
        {
            weekly_average = (cash_made * 7);//-UpkeepCost;
            cout <<weekly_average <<endl;
        }
        if (!strcmp("monthly",timecheck))
        {
            monthly_average = (cash_made * 30);//-UpkeepCost;
            cout <<monthly_average;
        } 
        if (!strcmp("yearly",timecheck))
        {
          yearly_average = (cash_made * 30);//-UpkeepCost;
          cout <<yearly_average;
        }

Since this is the C++ Board, you should use real strings and not those lousy slow zero-terminated thingys some people call strings =)

Can you spot an error ? A hint, return type...

Code:

char Machine_income(char timecheck,int cash_made);

int Machines::Machine_income(char timecheck,int cash_made)

In your ocde timecheck is a char, strcmp used char* as arguments.

Code:

if (!strcmp("daily",timecheck))

Wouldnt it be a good idea to use either 10 or 20 ?

Code:

  char timecheck[10];
  // code..
  cin.getline(timecheck,20);

What is this ? Shouldnt there be some values in there ?

Code:

cout <<p.Machine_income(char timecheck,int cash_made);

"7stud I am not trying to make an enumeration, I can do that."

As everyone who has responded to this thread knows, you certainly don't understand what an enumeration is. You cannot compare an enumerated type to a string--that was the point of the code I posted. Do you see why?

I don't know what you mean by this statement:

"In your ocde timecheck is a char, strcmp used char* as arguments."

Code:

if (!strcmp("daily",timecheck))

Please explain.

Got it working......thanks for all you people who helped. If anyone wants the code to see how it runs just ask me and I will post it.