Thread: I'm rusty and I need help

don't put ' ' around variable names:

Code:

x = strlen('num');
//should be
x = strlen(num);

and the same goes for the switch statement

strlen is for C-style strings (char *) only. The C++ string class has a length() function. switch statements take an integral type as an argument, so a string would not work (a single character is an integral type though).

It would be useful if you would post exactly what error messages you are getting.

This is the code:

Code:

#include <iostream.h>
#include <stdlib.h>
#include <string>
using namespace std;

int main()
{
      int x = 0;
      string num;
      cout << "Input a Number.\n";
      cin >> num;
      x = length(num);
      string numLast = num.substr(x, -1);
      switch (numLast)
      {
      case '1': cout << num << "st.\n";
      break;
      case '2': cout << num << "nd.\n";
      break;
      case '3': cout << num << "rd.\n";
      default: cout << "\n" << num << "th.\n";
      }
      system("PAUSE");
      return 0;
}

These are the errors:
1. implicit declaration of function `int length(...)'
2. warning: cannot pass objects of type `string' through `...'
3. switch quantity not an integer
4. case label `'1'' not within a switch statement
5. break statement not within loop or switch
etc.

I know I'm being annoying, but it's just that PHP's messed up my C++ comprehension. PHP code would look like this:

Code:

function nSufx ($n) 
{ 
  switch (substr($n,-1)) 
  { 
     case 1: return $n.'st'; 
     case 2: return $n.'nd'; 
     case 3: return $n.'rd'; 
     default: return $n.'th'; 
  } 
}

Just in case you were wondering why my code sucks.

for "using namespace std;" to work you will need to include the right headers:

Code:

#include <iostream>
#include <cstdlib>
#include <string>
using namespace std;

int main()
{

string num;//why is this a string?
int x=0;
cout << "Input a Number.\n";

cin >> num;  
  
   x = num.length();//finding length of a string object (rather than char*)
      string numLast = num.substr(x, -1); //-1 wont work and i dont see why you are doing this
      switch (numLast) //you cant use a string here
      {
      case '1': cout << num << "st.\n";
      break;
      case '2': cout << num << "nd.\n";
      break;
      case '3': cout << num << "rd.\n";
      default: cout << "\n" << num << "th.\n";
      }
      system("PAUSE");
      return 0;
}


return 0
}

substring will take a string out of a string like:

Code:

string one("stringone");
string two("two");
string x;
x= one.substr(6)+two.substr(2);
//x equals "oneo"

or your code will take a string out of the center (except that you use a negative value)

so the real question is what are you trying to do since I don't understand your code at all...and the code i just posted wont work either

From the looks of it, what you want is:

Code:

int x = num.length();
char numLast = num[x - 1]; // Or equivalent expression...
switch(numLast)
{ ... etc ... }

A char is an integral type, so that will work.