Error Cannot Convert Parameter 1

[drdroid]

I'm working on my own version of corewars and I've come to a halt. I get this error... list:

D:\Programs\Projects\Corewars\main.cpp(19) : error C2446: '==' : no conversion from 'char *' to 'int'
        This conversion requires a reinterpret_cast, a C-style cast or function-style cast
D:\Programs\Projects\Corewars\main.cpp(19) : error C2040: '==' : 'int' differs in levels of indirection from 'char [3]'
D:\Programs\Projects\Corewars\main.cpp(19) : error C2446: '!=' : no conversion from 'char *' to 'int'
        This conversion requires a reinterpret_cast, a C-style cast or function-style cast
D:\Programs\Projects\Corewars\main.cpp(19) : error C2040: '!=' : 'int' differs in levels of indirection from 'char [3]'
D:\Programs\Projects\Corewars\main.cpp(24) : error C2446: '!=' : no conversion from 'char *' to 'int'
        This conversion requires a reinterpret_cast, a C-style cast or function-style cast
D:\Programs\Projects\Corewars\main.cpp(24) : error C2040: '!=' : 'int' differs in levels of indirection from 'char [3]'
D:\Programs\Projects\Corewars\main.cpp(24) : error C2446: '==' : no conversion from 'char *' to 'int'
        This conversion requires a reinterpret_cast, a C-style cast or function-style cast
D:\Programs\Projects\Corewars\main.cpp(24) : error C2040: '==' : 'int' differs in levels of indirection from 'char [3]'
D:\Programs\Projects\Corewars\main.cpp(43) : error C2664: 'class std::basic_istream<char,struct std::char_traits<char> > &__thiscall std::basic_istream<char,struct std::char_traits<char> >::get(char &)' : cannot convert parameter 1 from 'char *' to 
'char &'
        A reference that is not to 'const' cannot be bound to a non-lvalue

Edit: the newest code is in the next page.

[Prelude]

>else if(first[lp]=="/0" && second[lp]!="/0")
String literals and char literals are not the same. The escape character is \, not /.

>else if(first[lp]!="/0" && second[lp]=="/0")
String literals and char literals are not the same. The escape character is \, not /.

[drdroid]

Yah I tried changing that a while ago, though I changed it back. It doesn't do anything for the error messages.

[laasunde]

else if(first[lp]=="/0" && second[lp]!="/0")

should probably be

else if(first[lp]=='\0' && second[lp]!='\0')

Not sure if

data.get(*program[lp]);

is correct...

Not sure I understand why you need a for loop in charchech() ..

[drdroid]

Theres a loop because I'm doing it letter by letter. The loop only continues if each character is the same.

[laasunde]

But you have break; inside all of your if's so it will only run through your loop once, hence a bit meaningless.

[drdoidhere]

I'm trying to make my own function instead of strcmp. That's the entire point of making that function!

[droidhere]

explain more specifically what's wrong

[drdroid]

what's wrong with this though?

data.get(*program[lp]);

i tried data.get(&program[lp]) which is what I thought it had to be, and it came up with an error, no error came up with the *. I don't understand what you mean by uninitialized memory.

[laasunde]

You really should set your pointers to zero

char * program[30] = {0};

The problem with

data.get(*program[lp]);

is that you have not allocated any space for the pointers. You have only set aside memory to an array of pointers.

You probably need to do something like

for(int lp=0;lp!=30;lp++)
{
  program[lp] = new char[15]; 
  data.get(*program[lp]);
  cout << *program[lp] << endl;
  // more code
}

Now the address stored in program[] will pointer to a memory space that can hold 15 char's. I picked the number 15 randomly btw.

[Cat]

program[lp] is a pointer to a character (and the pointer points to nothing, e.g. it's a random address in memory)

*program[lp] is the value of the character at that unknown address


char * program[30]; is an array of character pointers, but none of them point to actual strings. They just hold random memory locations. There are no strings, nor is there memory set aside for the strings.

[drdroid]

ok... so what i did now was

char* programs[30];
char proglist[30];

then in main i put:

for(int lp=0;lp!=30;lp++)
	{
		programs[lp]=&proglist[lp];
		data.get(*programs[lp]);
		if(charcheck(programs[lp]," ")==true)
		{
			strcpy(programs[lp],"EMPTY SLOT");
		}
	}

[drdroid]

the problem now is that i have to cast the variables... or so it says in the errors:

D:\Programs\Projects\Corewars\main.cpp(20) : error C2446: '==' : no conversion from 'char *' to 'int'
        This conversion requires a reinterpret_cast, a C-style cast or function-style cast

(just one of the errors)

i dun know where it's trying to convert from a char to an int though.

[drdroid]

nm... i never knew there was a difference between ' and "

[drdroid]

now though, theres an error:

D:\Programs\Projects\Corewars\main.cpp(50) : error C2664: 'charcheck' : cannot convert parameter 1 from 'char *[21]' to 'char *'
        Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast

i've tried making char* first to char* first[21], but that doesn't make a difference. btw, here's the new code.