observer & virtual function

[hsv]

Hi ppl!

I need to write an observer, and this is what I've got so far:

#ifndef OB
#define OB
#include <iostream>
using namespace std;

class observer
{
	public:
	observer();
	virtual void update(subject s);
};

class subject
{
	vector<observer> observers;
	public:
	void add_observer(observer& ob);
	subject();
	void notify();	
};
inline subject::subject()
{
}
#endif

The problem: void update() won't take a subject! Why is that? It works with add_observer so it should work with update, right?
Does it show that i'm new to c++?

/Henrik

[IfYouSaySo]

There is a library (source code available) called Loki, that implements an observer. There is even a book that explains the source code more or less line by line. To be honest, I don't remember the exact details of the implementation well enough to help you, but it may be helpful if you downloaded Loki and looked at the observer source code. There's other neat stuff like smart pointers as well.

Just search for C++ and Loki on google and it should come up right away. Good luck.

[hsv]

Ok, I'll check it out.. thanks!

[hsv]

I couldn't find any observer there, but I changed update() to take an int (id of the subject).

Anyway.. a new problem!

void subject::notify()
{
	
	for(vector<observer>::iterator p = observers.begin(); p != observers.end(); p++)
	{
		p->update(subject_id); 
                }
}

What happens is that the update() in observer is called, not in it's sub-class. Why?

[CornedBee]

Because the vector stores actualy observer object. If you are to use polymorphism you must store pointers.

[hsv]

Thanks! works perfectly now..