Thread: combining 2 arrays

can anyone tell me why I am crashing when i run this ?
I am loading and then trying to combine 2 arrays to I can sort the final one:
thanks!

Code:

#include <iostream>
using std::cout;
using std::cin;
using std::cerr;
using std::endl;
using std::istream;
using std::ostream;
using std::ios;
#include <fstream>
using std::ifstream;
using std::ofstream;
#include <iomanip>
using std::left;
using std::right;
using std::setw;

void load (istream& infile, istream& infile2, ostream& outfile);


void main ()
	{
	
	
	ifstream infile("C:\\McD\\Cee_\\PROJECTS\\MyProjects_sem2\\HW_cpp\\HW7_4\\file1.txt");
	if(!infile)
		{ 
        cerr << "Cannot open input file" << endl;
		exit (1); 
		}
	
	ifstream infile2("C:\\McD\\Cee_\\PROJECTS\\MyProjects_sem2\\HW_cpp\\HW7_4\\file2.txt");
	if(!infile2)
		{ 
        cerr << "Cannot open input file" << endl;
		exit (1); 
		}
	
	
	ofstream outfile("7_4out.dat"); 
    if(!outfile)
		{ 
        cerr << "Cannot open output file" << endl; 
        exit(1); 
		}
	
	load(infile, infile2, outfile);
	
	
	} 


void load (istream& infile, istream& infile2, ostream& outfile)
	{
	
	int num[10];
	int num2[10];
	

	
	while (( infile ) && (infile2))  
		{
		
		for (int i = 0; i <10; i++)
			{
			for (int j = 0; j < 10; j++)
				{	
				
				infile >> num[i];
				if(num[i] ==-1) return;
				
				infile2 >> num2[j];
				if(num2[j] ==-1) return;
				
                                                                 //this is where i combine them..i think it's the problem?
				((num[i+10])=(num2[j]));
							
				cout << num[i] << endl;
				cout << num2[j] << endl;
			
					
				}//if

			
			}//if
				
		}//wh
	
	}//fx

num can only hold 10 elements but you are trying to place 110 elements in it. element i + 10 doesn't exist. Your nested loop in load isn't necessary.

actually for some things using namespace std does not work.
I would very much prefer to type one simple statement but....
no dice @ times...

I'm sure you'll run into a time when this is appropriate

Originally posted by HaLCy0n
Seems a lot of people do this for some reason. I would hate to have to type out all of those "using"s. All you need to put is "using namespace std;" and it will include everything in the std namespace. For more on namespaces in C++, http://faq.cprogramming.com/cgi-bin/...&id=1043284351

you could. i prefer not to though because of global pollution. but that's my preference.