Class problem

**Ivan!** · 03-11-2003

Here I have made a piece of code that SHOULD display "firstname lastname"
The problem I have is that I does compile but the program itself doesnt work.
I dont see the problem but maybe you guys do.

Code:

#include <iostream.h>
#include <string.h>
class Student
{
    friend void display(Student* s);
public:
	
	int marks[5];
    
	
	Student(char*fname,char*lname)
	{
		strcpy(fname,firstname);
		strcpy(lname,lastname);
	}
	~Student()
	{
	}
protected:
	int average[5];
	char firstname[10];
	char lastname[10];
};
void display(Student* s);
int main()
{
	Student I("firstname","lastname");
	display(&I);
	
	return 0;
}

void display(Student* s)
{
	cout<<s->firstname;
	cout<<" ";
	cout<<s->lastname;
}

**zMan** · 03-11-2003

Your code should read as follows:

Code:

	Student(char*fname,char*lname)
	{
		strcpy(firstname, fname);
		strcpy(lastname, lname);
	}

**Stoned_Coder** · 03-11-2003

In general for a class like this do something like this...

Code:

class student
{
    public:
         Student(char*fname,char*lname)
	{
		strcpy(firstname, fname);
		strcpy(lastname, lname);
	}

          ~Student()
	{
	}
        
           std::ostream& Display( std::ostream& strm)
            {
                strm << fname << " "<< lname ;
                return strm;
             }
   private: 
         // private members
};

std::ostream& operator << ( std::ostream& strm, const Student& stud )
{ 
     return stud.Display(strm);
}

Now no friendship need be granted and you have the option of making Display virtual should you want to derive from this class. In general if you can use a member func and not have to grant friendship then its the best way of doing it.
Now you can do...

Student student( "fred","bloggs");
cout << student<<endl;

Thread: Class problem

Thread Tools

Search Thread

Display

Class problem

Similar Threads

Mesh Class Design problem

Getting an error with OpenGL: collect2: ld returned 1 exit status

Class design problem

My Window Class

Returning an object from a method - Problem when creating my own string class