Thread: Any suggestion?

I am guessing something is not right. When I input a palindrome string for example 'madam' is says Not palindrome. Your help is appreciated.


#include<iostream.h>
#include<string.h>
//#include<stdlib.h>

int main()
{
//clrscr();
char arr[20]; //array to hold string
int len,ans=0,x,y;

cout<<"Enter : ";
cin>>arr; // string input

len=strlen(arr); // finding out string length,using a lib func

for (x=0,y=(len-1); x!=y ; x++,y--) //multiple var for loop
{
if (arr[x] == arr[y]) //increment palindrome checking counter ans++;
if (ans == (len/2) )// if palindrome checking counter is equal to half the string length,output"palindrome"
{
cout<<"Its a palindrome !!";
}
}

cout<<"Not a palindrome !";


return 0;
}

You don't have anything increment when the letters match. Make sure you have ans++ after your if statement.

Also, change your for statement to say x<y instead of x!=y. Otherwise, even number word lengths will send it into an infinite loop since for example length 2:

x=0 y=1
x=1 y=0
x=2 y=-1
etc.

I did changed to your suggestion but it didn't work for some reason. Thanks though.

The previous post was right on. You need to make sure the condition for the for..loop is x<y and you need to increment ans++. The one thing that wasn't mentioned in the post is that you need to initialize ans to 1 not 0. This will solve the problem. BTW cout<<"Not a palindrome !"; will always print because there is no condition statement testing whether it should or not. You'll see this after you run your program with the corrections.

Good Luck