Thread: Problem with Functions!

Why wont this work?? It shows the right answer in the input function but some wierd number in the main... any ideas?

Code:

#include<iostream.h>
#include<iomanip.h>
#include<conio.h>
#include<string.h>
#include<math.h>
#include<time.h>
#include<stdlib.h>

struct info
{
        int number;
};


void input()
{
        info vars;
        cout<<"Enter a number: ";
        cin>>vars.number;
        /******************************************
                      IT WORKS HERE
        ******************************************/
        cout<<vars.number;
}

main()
{
        info vars;
        input();
        cout<<endl;
        /******************************************
                      BUT NOT HERE
        ******************************************/
        cout<<vars.number;
        getch();
}

I also tried declaring the structure globally and still it works in the input function but gives me a zero in the main. Any help would be greatly appreciated.

Code:

#include<iostream.h>
#include<iomanip.h>
#include<conio.h>
#include<string.h>
#include<math.h>
#include<time.h>
#include<stdlib.h>

struct info
{
        int number;
};

info vars;

void input(info vars)
{
        cout<<"Enter a number: ";
        cin>>vars.number;
        /******************************************
                      IT WORKS HERE
        ******************************************/
        cout<<vars.number;
}

main()
{
        input(vars);
        cout<<endl;
        /******************************************
                      BUT NOT HERE
        ******************************************/
        cout<<vars.number;
        getch();
}

Simple. you output the number twice when you dont need to.

Code:

#include<iostream.h>
#include<iomanip.h>
#include<conio.h>
#include<string.h>
#include<math.h>
#include<time.h>
#include<stdlib.h>

struct info
{
        int number;
};


void input()
{
        info vars;
        cout<<"Enter a number: ";
        cin>>vars.number;
        /******************************************
                      IT WORKS HERE
        ******************************************/
        cout<<vars.number; //YOU ONLY OUTPUT NUMBERHERE IN FUNCTION
}
 main()
{       info vars;
        input();
        cout<<endl;
        /******************************************
                      BUT NOT HERE
        ******************************************/
        getch();
        //cout<<vars.number; //YOU DONT NEED THIS LINE

}

When you put cout<<vars.number in main you are reprinting the numebr you already printed in your input function.

HOPE THAT HELPS!

first of all which one works?
second becuase the project im working on must be slpit up into functions.

Originally posted by gamer4life687
Simple. you output the number twice when you dont need to.

When you put cout<<vars.number in main you are reprinting the numebr you already printed in your input function.

HOPE THAT HELPS!

Actually i only want to display it in the main which still does not work if i take out the cout<<vars.number in the input function

keep the possible sollutions coming!

yeah i know what you are saying but it is not that tho.
i must call the variable from the structure into main.

im damn sure ya can do it since i my teacher did it in class today.

hmm okay what i need to do is write an app that asks the comp to guess a random number. the app has to be split up into 3 functions and the main and the variables must be stored in the structure.

it has to be set up like this

struct

inputFunction()

randomFunction()

outputFunction()

main()

i dont know if you understand what im talking about but thats pretty much what i am trying to acomplish, but first i am just trying to figure out how to send variables to the structure and then display them in a different function.

here is the reason why it does not print the right answer in main to the screen.

when you call input, it reserves memory for its own info.

however, when you are to call it in main, it will not alter main's 'info vars' because in input, 'info vars' is a local variable for that function.

for example...

Code:

void func()
{
        int x;

        cin >> x;
        cout << x;
}

//if you enter 10 for x here, it will output 10.

int main()
{
       int x;

       cout << x;
}
//it will NOT output 10 here because x in main is local to main.  they are two different memory locations, not the same memory.

//I'm sure you already know this and just forgot...

alpha i sort of already established that i know thats its different output and i know how to output it. The only prob is i dont know how he wanted to and know i do but i have to get off right now.
Sorry hope someone else will help you!!

Oops i put my wrong user name lol

gamers...I know, but with his initial code, thats the way it was setup