Thread: Whats wrong with this code?

Originally posted by skipper
>I gotta get this dam project done by tommorrow cuz its due!


>Mabe some of you guys could fix some of my code so it's proper and may even work.
C'mon.

-Skipper

cmon what? This forum is used to help and others helping in eachothers code and problems. No harm in asking to help fix my code

Attach the file you need to use with this code. "assign6", I'll take a look.

OK here

did ya get it?

anyone else on .02?

well now im getting this

C:\Program Files\Microsoft Visual Studio\assign6\assign6.cpp(161) : error C2665: 'basic_ifstream<char,struct std::char_traits<char> >::basic_ifstream<char,struct std::char_traits<char> >' : none of the 3 overloads can convert parameter 2 from type '
char [3]'
C:\Program Files\Microsoft Visual Studio\assign6\assign6.cpp(186) : error C2065: 'dls_store' : undeclared identifier

from this code:

Code:

/* Load the address file. */
void load()
{
  struct record *info;
  FILE *fp;

  fp = ifstream("assign6", "rb");
  if(!fp) {
    cout << ("Cannot open file.\n");
    exit(1);
  }


  /* free any previously allocated memory */
  while(start) {
    info = start->next;
    free(info);
    start = info;
  }

  /* reset top and bottom pointers */
  start = last = NULL;

  printf("\nLoading File\n");
  while(!feof(fp)) {
    info = (struct record *) malloc(sizeof(struct record));
    if(!info) {
      printf("Out of Memory");
      return;
    }
    if(1 != fread(info, sizeof(struct record), 1, fp)) break;
    dls_store(info, &start, &last);
  }
  fclose(fp);
}

>> FILE *fp;
>> fp = ifstream("assign6", "rb"); //Dragons be here

Leave the code as it was :

Code:

fp = fopen("assign6.txt", "rb");
if(!fp) {
    cout << ("Cannot open file.\n");
    exit(1);
}

Also, in your while loop, try not to use feof() as the loop condition, instead use fread(), like so :

Code:

info = (struct record *)malloc( sizeof(struct record) );
if ( !info ) return;
while( 1 == fread(info, sizeof( struct record ), 1, fp ) ) ) {
      dls_store(info, &start, &last);
}

And about this :

Code:

/* free any previously allocated memory */
while(start) {
    info = start->next;
    free(info);
    start = info;       //why ???
}

//Did you mean to do this?
info = start;
struct record *temp;
while( info ) {
    temp = info;
    info = info->next;
    free(temp);
}

If you still have problems, then it's probably in your dls_store() function.