skipping input

**cheeisme123** · 09-24-2002

Hi I have a problem with an input line in my code. When it should ask for the input for "name" it skips over it and goes to the imput for "school". What am I missing.

Input screen
-------------------
Title: Manager
Number: 21
Name: School: DeVry //this is where the problem is
Degree: BSC

Output screen
-------------------
Title: Manager
Number: 21
Name: //see, it skipped the imput
School: DeVry
Degree: BSC
Press any key to continue

This is my code:
--------------------------

Code:

#include<iostream.h>
#include<string.h>
#include<conio.h>

class Student
{
private:
	char school[20];
	char degree[20];
public:
	void getData();
	void putData();
};

class Employee
{
private:
	char name[20];
	int num;
public:
	void getData();
	void putData();
};

class Manager
{
private:
	char title[20];
	Employee em;
	Student st;
public:
	void getData();
	void putData();
};

void Student::getData()
{
	cout<<"School: ";
	cin.getline(school, 20, '\n');
	cout<<"Degree: ";
	cin.getline(degree, 20, '\n');
}

void Student::putData()
{
	cout<<"School: "<<school<<endl;
	cout<<"Degree: "<<degree<<endl;
}

void Employee::getData()
{
	cout<<"Number: ";
	cin>>num;
	cout<<"Name: ";                       //THIS IS THE PROBLEM
	cin.getline(name, 20, '\n');
}

void Employee::putData()
{
	cout<<"Number: "<<num<<endl;
	cout<<"Name: "<<name<<endl;
}

void Manager::getData()
{
	cout<<"Title: ";
	cin.getline(title, 20, '\n');
	em.getData();
	st.getData();
}

void Manager::putData()
{
	cout<<"Title: "<<title<<endl;
	em.putData();
	st.putData();
}

void main (void)
{
	Manager m;
	m.getData();
	m.putData();
	return;
}

Code tags added by Kermi3

**Stoned_Coder** · 09-24-2002

You are mixing calls to cin >> and cin.getline. this can cause trouble as you have found. The behaviour is caused because cin>> leaves a \n in the streambuf which is read by the cin.getline call and taken as input. use cin.ignore() to rid the newline from the streambuf.

**WebmasterMattD** · 09-24-2002

I would suggest getting out of the world of C based string and use the C++ string datatype.

This way, when you get the input for the string you can use
getline(cin, stringName);
and then place a
cin.get();
to get rid of the pesky character return that will pop up next time you call getline and really stuff things up.

This should help with the errors in your program.
Later,

***kermi3*** · 09-25-2002

In the furture please use Code Tags. People will be much more likely to help you if you do. And they'll be happy about it

Information on code tags may be found at:

http://www.cprogramming.com/cboard/...&threadid=13473

**Sang-drax** · 09-25-2002

I use the following to remove every character waiting in the buffer and to reset cin.
Nothing else I've tried has been completely "user-proof".

Code:

 
    void flush_input()
    {
        //Clear all error flags
        std::cin.clear();
        //Remove all characters waiting to be read
        while (std::cin.rdbuf()->in_avail() > 0) std::cin.get();
    }

**endo** · 09-25-2002

Originally posted by Sang-drax
I use the following to remove every character waiting in the buffer and to reset cin.
Nothing else I've tried has been completely "user-proof".

Nothing is ever "user-proof", I'm sure many people here agree

**Sang-drax** · 09-25-2002

Originally posted by endo
Nothing is ever "user-proof", I'm sure many people here agree

That is true indeed

However my function prevents strange behaviour when the user enters two numbers or a string when I ask for an int etc.
But user-proof... no, it's not user-proof.

Thread: skipping input

Thread Tools

Search Thread

Display

skipping input

Code Tags

Similar Threads

Input class project (again)

I would love some input on my BST tree.

About aes

Structure and Linked List User Input Question

need help with some input