Thread: Access Violation!!

Code:

char** Delete(char** Names){ // <---- here?
	cout << "Name: ";
   cin >> temp1;
   for (int x=0; x<=count; x++){
   	if (strcmp(Names[count], temp1)){ // <<----- I think it is here...
      	cout << "Deleted\n";
         return (Names);
      }
      if (x==count){
      	cout << "Not found!!\n";
         return 0;
      }
   }

}

Thank you.

I tried everything... from 2-d arrays to pointers... Ac Vi always.

almost certainly you are overstepping the bounds of your array in the loop. try < instead of <= and see what happens. hard to tell from snippet but thats my educated guess.

Should probably be Names[x] and not Names[count] perhaps.

Nope, still doesn't work

Code:

#include<iostream.h>
#include<stdio.h>
#include<string.h>

int count = 0;
char*  temp1;


char** Add(char** Names){
   count++;
   Names = new char*[count];
	cout << "Name: ";
   cin >> Names[count];
   return (Names);
}


char** Delete(char** Names){
	cout << "Name: ";
   cin >> temp1;
   for (int x=0; x<count; x++){
   	if (strcmp(Names[x], temp1)){
      	cout << "Deleted\n";
         return (Names);
      }
      if (x-1==count){
      	cout << "Not found!!\n";
         return 0;
      }
   }

}


void Find(char** Names){
	cout << "Name: ";
   cin >> temp1;
   for (int x=0; x<count; x++){
   	if (strcmp(Names[x], temp1)){
      	cout << "Found at Location " << count;
         return;
      }
      if (x-1==count){
      	cout << "Not found!!\n";
         return;
      }
   }

}


int main(){
   char choice;
   char* Names[1];
   do{
   	cout << "Choose action (Add/Delete/Find/Quit): ";
   	cin >> choice;
   	if (choice == 'A' || choice == 'a')
	   	Add(Names);
   	else if (choice == 'D' || choice == 'd')
   		Delete(Names);
   	else if (choice == 'F' || choice == 'f')
   		Find(Names);
   	else{
      	return 0;
   	}
	}while(choice !='q' || choice != 'Q');
   delete Names;
   return 0;

}

the full code.

>>char* Names[1];
An array of 1 ? Seems a bit strange to me.

>>Add(Names);
The Add() function returns something, but you aren't assigning it to anywhere.

There's a few others too, but I don't have time right now to show you them.