Thread: Help with loop

Hey, I'm making this game, you have to select 0-7 for a row and 0-7 for a column, Now this is what I have:

Code:

 char *column2;
   char *row2;

   do
   {

   do
   {
   	cout << " \nEnter column: C- ";
      cin >> column2;
      cin.ignore(80,'\n');
      column=atoi(column2);

   } while(column > '7');

   do
   {
		cout << "\nEnter Row R- ";
      cin>> row2;
      cin.ignore(80,'\n');

      row=atoi(row2);

   } while(row > '7');

   if(board[row][column] == 'X')
   {
   	piecevalid++;
   }else{
   	cout << " \nPlease select a valid piece\n";
   }

   } while(piecevalid != 1);

Now If i just did INT, then if someone typed C it would go in a infinate loop, now This prevents the infinite loop but ppl can enter 9 and E and it will have no affect, meaning that it will pass through the loop.

IF I enetered F and F it would just continue on and say I selected 0,0.

Any suggestions?

Use std::getline(cin, string)

Kuphryn

Code:

char column2;
char row2;


do
{

   do
   {
      cout << " \nEnter column: C- ";
      cin >> column2;
      cin.ignore(80,'\n');
      column=atoi(column2);

   } while(column > 7);  // column should be an int, not a char, so dont compare to a char

   do
   {
		cout << "\nEnter Row R- ";
      cin>> row2;
      cin.ignore(80,'\n');

      row=atoi(row2);

   } while(row > 7);  //same with row. compare it to an int, not a char

   if(board[row][column] == 'X')
   {
   	piecevalid++;
   }else{
   	cout << " \nPlease select a valid piece\n";
   }

   } while(piecevalid != 1);

your code was not behaving correctly, because you were comparing an int, to the ascii value of the char '7' instead of comparing to 7

I get:
Error: checkers.cpp(320,27):Cannot convert 'int' to 'const char *'
Error: checkers.cpp(320,27):Type mismatch in parameter '__s' in call to 'atoi(const char *)'
Error: checkers.cpp(330,21):Cannot convert 'int' to 'const char *'
Error: checkers.cpp(330,21):Type mismatch in parameter '__s' in call to 'atoi(const char *)'

oops, sorry about that
change the vars to

char column2[10], row2[10];

that should work

alright thanks a lot