Thread: Scrabble rack generator (not really)

Your code segfaults on single-letter words for me.
Also, you should seed the rng so it's different each run.
random_shuffle() uses rand() so you seed it with srand().

Code:

#include <algorithm>
#include <iostream>
#include <string>
#include <cctype>
#include <cstdlib>
#include <ctime>
 
using namespace std;
 
int main()
{
  srand(time(0));
 
  string word;
  bool done = false;
 
  while (!done && cin >> word) {
    auto last = word.end() - 1;
 
    if (ispunct(*last)) {
      done = (*last == '.' || *last == '?' || *last == '!');
      --last;
    }
 
    auto dist = distance(word.begin()+1, last);
 
    if (dist == 2) // always swap middle letters of 4-letter words (maybe?)
      swap(word.begin()[1], last[-1]);
    else if (dist > 2)
      random_shuffle(word.begin()+1, last);
 
    cout << word << ' ';
  }
 
  cout << '\n';
 
  return 0;
}

random_shuffle() has been removed from C++ since C++17.
You can use shuffle() instead which uses the <random> library instead of rand().

Code:

#include <algorithm>
#include <iostream>
#include <random>
#include <string>
#include <cctype>
 
using namespace std;
 
int main()
{
  random_device rd;
  minstd_rand g(rd());
 
  string word;
  bool done = false;
 
  while (!done && cin >> word) {
    auto last = word.end() - 1;
 
    if (ispunct(*last)) {
      done = (*last == '.' || *last == '?' || *last == '!');
      --last;
    }
 
    auto dist = distance(word.begin()+1, last);
 
    if (dist == 2) // always swap middle letters of 4-letter words (maybe?)
      swap(word.begin()[1], last[-1]);
    else if (dist > 2)
      shuffle(word.begin()+1, last, g);
 
    cout << word << ' ';
  }
 
  cout << '\n';
 
  return 0;
}

Hello John, thanks for your comments. I figured that supplying a generator would be one of the first changes people would make. I didn't want to bother so I used an older standard. Next time I write the program I'll have to be more careful about words like I or a. Nice find. There are definitely things I would have done different if I was interested in making the program more robust... Like letting it work on multiple lines.

It's just the kind of shoddy quality you get from me if I only spend 30 minutes on something.

Something I learned from your rewrite now, actually:

Code:

    if (dist == 2) // always swap middle letters of 4-letter words (maybe?)
      swap(word.begin()[1], last[-1]);

I didn't know operator[] was defined for string iterators!

Although, to respond to the comment, personally I thought leaving some words alone by chance was an even better prank.

What about a 5-letter word? There's a 1 in 6 chance that it'll be untouched too.

So there's a good chance that one of the words in these sentences will stay the same:

Alice reads books. Bobby reads books.

I'd also just let the shuffle do its job and let it produce untouched results some of the time.

If you wanted to guarantee that a word will always be different than the original, you could put the shuffling in a loop, and if the word is 4 letters or longer and the shuffled version is the same as the original, repeat the loop. That way you don't have to handle 4-letter words specifically.

Edit: I didn't consider cases where all of the inside letters are the same, as in "book" or "booooook". That would make the loop infinitely repeat. So you would need another test to see if all the letters are the same; if they are, just break out of the loop (or don't enter the loop in the first place).