Thread: Where am I going wrong?

Code:

#include<string>#include<iostream>
using namespace std;


class Dog
{
	
	void setValues( int, int, string);
	
	public:
	void bark(){cout << "WOOF!" << endl;}
	void setAge(int yrs) {age = yrs;}
	void setWeight ( int ibs ) { weight = ibs ; }
	void setColor (string hue ) { color = hue ; }
	
	int getAge() { return age ; }
	int getWeight() { return weight ; }
	string getColor() { return color ; }
	
};
void Dog::setValues ( int age, int weight, string color)
{
	this->age = age;
	this->weight = weight;
	this->color = color;
}


int main()
{
		
	Dog fido;
	fido.setValues( 3, 15, "brown");
	
	cout << "Fido is a " << fido.getColor() << " dog " << endl;
	cout << "Fido is " << fido.getAge() << " years old."  << endl;
	cout << "Fido weighs  " << fido.getWeight() << " pounds " << endl;
	
	fido.bark();
	
	Dog pooch;
	pooch.setValues( 4, 18, "gray" );
	
	cout << "Pooch is a " << pooch.getAge();
	cout << " year old " << pooch.getColor();
	cout << " dog who weighs " << pooch.getWeight();
	cout << " pounds. ";
	
	pooch.bark();
	return 0;
}

Code:

main.cpp: In member function ‘void Dog::setAge(int)’:
main.cpp:12:24: error: ‘age’ was not declared in this scope
   12 |  void setAge(int yrs) {age = yrs;}
      |                        ^~~
main.cpp: In member function ‘void Dog::setWeight(int)’:
main.cpp:13:31: error: ‘weight’ was not declared in this scope
   13 |  void setWeight ( int ibs ) { weight = ibs ; }
      |                               ^~~~~~
main.cpp: In member function ‘void Dog::setColor(std::string)’:
main.cpp:14:32: error: ‘color’ was not declared in this scope
   14 |  void setColor (string hue ) { color = hue ; }
      |                                ^~~~~
main.cpp: In member function ‘int Dog::getAge()’:
main.cpp:16:24: error: ‘age’ was not declared in this scope
   16 |  int getAge() { return age ; }
      |                        ^~~
main.cpp: In member function ‘int Dog::getWeight()’:
main.cpp:17:27: error: ‘weight’ was not declared in this scope
   17 |  int getWeight() { return weight ; }
      |                           ^~~~~~
main.cpp: In member function ‘std::string Dog::getColor()’:
main.cpp:18:29: error: ‘color’ was not declared in this scope
   18 |  string getColor() { return color ; }
      |                             ^~~~~
main.cpp: In member function ‘void Dog::setValues(int, int, std::string)’:
main.cpp:23:8: error: ‘class Dog’ has no member named ‘age’
   23 |  this->age = age;
      |        ^~~
main.cpp:24:8: error: ‘class Dog’ has no member named ‘weight’
   24 |  this->weight = weight;
      |        ^~~~~~
main.cpp:25:8: error: ‘class Dog’ has no member named ‘color’
   25 |  this->color = color;
      |        ^~~~~
main.cpp: In function ‘int main()’:
main.cpp:32:32: error: ‘void Dog::setValues(int, int, std::string)’ is private within this context
   32 |  fido.setValues( 3, 15, "brown");
      |                                ^
main.cpp:21:6: note: declared private here
   21 | void Dog::setValues ( int age, int weight, string color)
      |      ^~~
main.cpp:41:33: error: ‘void Dog::setValues(int, int, std::string)’ is private within this context
   41 |  pooch.setValues( 4, 18, "gray" );
      |                                 ^
main.cpp:21:6: note: declared private here
   21 | void Dog::setValues ( int age, int weight, string color)       |      ^~~

Originally Posted by Salem

You have a bunch of member functions, but no member variables.

> main.cpp:23:8: error: ‘class Dog’ has no member named ‘age’
> 23 | this->age = age;

But the book showed the code in that form. The member variables go into the main block or the class block?

Originally Posted by Salem

Maybe you need a better book.


Maybe you mis-read also.
The abbreviation for 'pounds' is 'lbs', not 'ibs'.

Now you are just being smug and not helpful. I could use a new book, but still. It won't help if I didn't get something as simple as encapsulation and how to do it right.

Post a picture of the code from the book? Then we can see if the book is maybe worth learning from.

Originally Posted by christop

Post a picture of the code from the book? Then we can see if the book is maybe worth learning from.

I originally could compile it successfully, only when I added more did things go wrong...

Originally Posted by Salem

> I originally could compile it successfully, only when I added more did things go wrong...
Maybe you should show that as well.
Because what you posted makes no mention of the need to have member variables.

Bullet point 4 suggests you need them.

Code:

#include<string>#include<iostream>
using namespace std;


class Dog
{
    
    int age, weight;
    string color;
    
    public:
    void bark(){cout << "WOOF!" << endl;}
    void setAge(int yrs) {age = yrs;}
    void setWeight ( int ibs ) { weight = ibs ; }
    void setColor (string hue ) { color = hue ; }
    
    int getAge() { return age ; }
    int getWeight() { return weight ; }
    string getColor() { return color ; }
};


int main()
{
    Dog fido;
    fido.setAge( 3 );
    fido.setWeight( 15 );
    fido.setColor( "brown");
    
    cout << "Fido is a " << fido.getColor() << " dog " << endl;
    cout << "Fido is " << fido.getAge() << " years old."  << endl;
    cout << "Fido weighs  " << fido.getWeight() << " pounds " << endl;
    
    fido.bark();
    
    return 0;
}

Originally Posted by Salem

Right, so in between the code in post #10 and the code in post #1, why did you delete the member variables?

It said to do it.

Ok, can you suggest a book?

Originally Posted by Salem

Where?

I saw no mention of telling you to delete or change anything to do with the member variables.

Perhaps you need a better book (still).
Just copying from a book which basically amounts to telling you what to type isn't teaching you how to program.