Thread: Priority of checking build warnings?

Code:

1. overloaded-virtual   clang
1. potentially-evaluated-expression  clang
1. free-nonheap-object  GCC
4. maybe-uninitialized  GCC
5. unused-const-variable clang
6. deprecated-declarations GCC and clang

I am building an MSys2 MinGW64 package that uses either GCC or CLANG to build an C++ wxWidgets package called KICAD.

I am building it and planning to check the build warnings.
I am not sure which of the top 3 "number 1" are more important to check. Any advise?

Edit: I have no plans to check "deprecated-declarations" warnings. So many it would be a waste of my time.

Tim S.

My order, just based on a bit of reading.

3. overloaded-virtual clang
c++ overloaded virtual function warning by clang? - Stack Overflow
It depends what the programmer was trying to achieve.
Like other shadowing issues where one scope hides another, mostly it's a mistake, but could be intentional.

2. potentially-evaluated-expression clang
c++ - What is a potentially-evaluated expression? - Stack Overflow


1. free-nonheap-object GCC
Assuming it's not a false positive, this would seem to be an actual bug at run-time.
Depending how robust your allocator is at freeing unknown pointers, the effect is somewhere between a nop and a crash.

Thanks, I am now planning to cut out the code generating the warning to a small test case. In the order you suggested.

The code with warning is not obvious right or wrong to me.
I hope the small test cases will allow fast testing of ways to get rid of the warnings.

Tim S.