Thread: undefined reference to `PacketProcessor::SetSeqStart(unsigned char)'|

  1. #1
    Registered User
    Join Date
    Jun 2021
    Posts
    31

    undefined reference to `PacketProcessor::SetSeqStart(unsigned char)'|

    I'm getting this error when trying to compile my c++ program, does anyone know where to start to fix this? undefined reference to `PacketProcessor::SetSeqStart(unsigned char)'|

  2. #2
    and the hat of int overfl Salem's Avatar
    Join Date
    Aug 2001
    Location
    The edge of the known universe
    Posts
    38,815
    Is PacketProcessor one of your classes, or something you've downloaded?

    A few common mistakes are
    - not implementing the function (despite mentioning it in the class)
    - getting the type wrong when you call it
    - typo's in either how you define, declare or use the function name.

    Edit: also here -> undefined reference to `PacketProcessor: - C++ Forum
    If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
    If at first you don't succeed, try writing your phone number on the exam paper.

  3. #3
    Registered User
    Join Date
    Jun 2021
    Posts
    31
    I'm pretty sure its one of my classes

  4. #4
    Registered User
    Join Date
    Jun 2021
    Posts
    31
    I'm trying to change some of the source code around and when I do what a tutorial says I get error undefined reference to `PacketProcessor::SetSeqStart(unsigned char)'| perhaps I could show you what I'm trying to change?

  5. #5
    and the hat of int overfl Salem's Avatar
    Join Date
    Aug 2001
    Location
    The edge of the known universe
    Posts
    38,815
    Who can say without some visibility of code you've actually written.
    If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
    If at first you don't succeed, try writing your phone number on the exam paper.

  6. #6
    Registered User
    Join Date
    Jun 2021
    Posts
    31
    okay so basically I didn't write it but here is the first part this is the packet.cpp (EDIT)

    Code:
    #include "packet.hpp"
    
    PacketProcessor::PacketProcessor()
    {
        this->firstdec = true;
        this->seqval = 1;
    }
    
    std::string PacketProcessor::GetFamilyName(PacketFamily family)
    {
        switch (family)
        {
            case PACKET_CONNECTION: return "Connection";
            case PACKET_ACCOUNT: return "Account";
            case PACKET_CHARACTER: return "Character";
            case PACKET_LOGIN: return "Login";
            case PACKET_WELCOME: return "Welcome";
            case PACKET_WALK: return "Walk";
            case PACKET_FACE: return "Face";
            case PACKET_CHAIR: return "Chair";
            case PACKET_EMOTE: return "Emote";
            case PACKET_ATTACK: return "Attack";
            case PACKET_SHOP: return "Shop";
            case PACKET_ITEM: return "Item";
            case PACKET_STATSKILL: return "StatSkill";
            case PACKET_GLOBAL: return "Global";
            case PACKET_TALK: return "Talk";
            case PACKET_WARP: return "Warp";
            case PACKET_JUKEBOX: return "Jukebox";
            case PACKET_PLAYERS: return "Players";
            case PACKET_CLOTHES: return "Clothes";
            case PACKET_PARTY: return "Party";
            case PACKET_REFRESH: return "Refresh";
            case PACKET_NPC: return "NPC";
            case PACKET_AUTOREFRESH: return "AutoRefresh";
            case PACKET_APPEAR: return "Appear";
            case PACKET_PAPERDOLL: return "Paperdoll";
            case PACKET_EFFECT: return "Effect";
            case PACKET_TRADE: return "Trade";
            case PACKET_CHEST: return "Chest";
            case PACKET_DOOR: return "Door";
            case PACKET_PING: return "Ping";
            case PACKET_BANK: return "Bank";
            case PACKET_LOCKER: return "Locker";
            case PACKET_GUILD: return "Guild";
            case PACKET_SIT: return "Sit";
            case PACKET_BOARD: return "Board";
            case PACKET_ARENA: return "Arena";
            case PACKET_ADMININTERACT: return "AdminInteract";
            case PACKET_CITIZEN: return "Citizen";
            case PACKET_QUEST: return "Quest";
            case PACKET_BOOK: return "Book";
            case PACKET_F_INIT: return "Init";
            default: return "UNKNOWN";
        }
    }
    
    std::string PacketProcessor::GetActionName(PacketAction action)
    {
        switch (action)
        {
            case PACKET_REQUEST: return "Request";
            case PACKET_ACCEPT: return "Accept";
            case PACKET_REPLY: return "Reply";
            case PACKET_REMOVE: return "Remove";
            case PACKET_AGREE: return "Agree";
            case PACKET_CREATE: return "Create";
            case PACKET_ADD: return "Add";
            case PACKET_PLAYER: return "Player";
            case PACKET_TAKE: return "Take";
            case PACKET_USE: return "Use";
            case PACKET_BUY: return "Buy";
            case PACKET_SELL: return "Sell";
            case PACKET_OPEN: return "Open";
            case PACKET_CLOSE: return "Close";
            case PACKET_MSG: return "Msg";
            case PACKET_SPEC: return "Spec";
            case PACKET_ADMIN: return "Admin";
            case PACKET_LIST: return "List";
            case PACKET_TELL: return "Tell";
            case PACKET_REPORT: return "Report";
            case PACKET_ANNOUNCE: return "Announce";
            case PACKET_SERVER: return "Server";
            case PACKET_DROP: return "Drop";
            case PACKET_JUNK: return "Junk";
            case PACKET_GET: return "Get";
            case PACKET_NET: return "Net";
            case PACKET_NET2: return "Net2";
            case PACKET_NET3: return "Net3";
            case PACKET_A_INIT: return "Init";
            default: return "UNKNOWN";
        }
    }
    
    std::string PacketProcessor::Decode(const std::string &str)
    {
        std::string newstr;
        int length = str.length();
        int i = 0;
        int ii = 0;
    
        if (this->firstdec)
        {
            this->firstdec = false;
            return str;
        }
    
        newstr.resize(length);
    
        while (i < length)
        {
            newstr[ii++] = (unsigned char)str[i] ^ 0x80;
            i += 2;
        }
    
        --i;
    
        if (length % 2)
        {
            i -= 2;
        }
    
        do
        {
            newstr[ii++] = (unsigned char)str[i] ^ 0x80;
            i -= 2;
        } while (i >= 0);
    
        for (int i = 2; i < length; ++i)
        {
            if (static_cast<unsigned char>(newstr[i]) == 128)
            {
                newstr[i] = 0;
            }
            else if (newstr[i] == 0)
            {
                newstr[i] = 128;
            }
        }
    
        return this->DickWinderD(newstr);
    }
    
    std::string PacketProcessor::Encode(const std::string &rawstr)
    {
        std::string fullstr;
    
        if (rawstr[1] != 255)
        {
            fullstr += rawstr.substr(0,4);
            fullstr += this->Sequence();
            fullstr += rawstr.substr(4);
        }
    
        std::string str = this->DickWinderE(fullstr);
        std::string newstr;
        int length = str.length();
        int i = 2;
        int ii = 2;
    
        newstr.resize(length);
    
        newstr[0] = str[0];
        newstr[1] = str[1];
    
        while (i < length)
        {
            newstr[i] = (unsigned char)str[ii++] ^ 0x80;
            i += 2;
        }
    
        i = length - 1;
    
        if (length % 2)
        {
            --i;
        }
    
        while (i >= 2)
        {
            newstr[i] = (unsigned char)str[ii++] ^ 0x80;
            i -= 2;
        }
    
        for (int i = 2; i < length; ++i)
        {
            if (static_cast<unsigned char>(newstr[i]) == 128)
            {
                newstr[i] = 0;
            }
            else if (newstr[i] == 0)
            {
                newstr[i] = 128;
            }
        }
    
        return newstr;
    }
    
    std::string PacketProcessor::DickWinder(const std::string &str, unsigned char emulti)
    {
        std::string newstr;
        int length = str.length();
        std::string buffer;
        unsigned char c;
    
        if (emulti == 0)
        {
            return str;
        }
    
        for (int i = 0; i < length; ++i)
        {
            c = str[i];
    
            if (c % emulti == 0)
            {
                buffer += c;
            }
            else
            {
                if (buffer.length() > 0)
                {
                    std::reverse(buffer.begin(), buffer.end());
                    newstr += buffer;
                    buffer.clear();
                }
                newstr += c;
            }
        }
    
        if (buffer.length() > 0)
        {
            std::reverse(buffer.begin(), buffer.end());
            newstr += buffer;
        }
    
        return newstr;
    }
    
    std::string PacketProcessor::DickWinderE(const std::string &str)
    {
        return PacketProcessor::DickWinder(str, this->emulti_e);
    }
    
    std::string PacketProcessor::DickWinderD(const std::string &str)
    {
        return PacketProcessor::DickWinder(str, this->emulti_d);
    }
    
    void PacketProcessor::SetEMulti(unsigned char emulti_e, unsigned char emulti_d)
    {
        this->emulti_e = emulti_e;
        this->emulti_d = emulti_d;
    }
    
    void PacketProcessor::SetSeqStart(unsigned char val)
    {
        this->seqstart = val;
    }
    
    unsigned char PacketProcessor::Sequence()
    {
        int val = this->seqval;
    
        if (++this->seqval >= 10)
        {
            this->seqval = 0;
        }
    
        return this->seqstart + val;
    }
    
    unsigned int PacketProcessor::Number(unsigned char b1, unsigned char b2, unsigned char b3, unsigned char b4)
    {
        if (b1 == 0 || b1 == 254) b1 = 1;
        if (b2 == 0 || b2 == 254) b2 = 1;
        if (b3 == 0 || b3 == 254) b3 = 1;
        if (b4 == 0 || b4 == 254) b4 = 1;
    
        --b1;
        --b2;
        --b3;
        --b4;
    
        return (b4*PacketProcessor::MAX3 + b3*PacketProcessor::MAX2 + b2*PacketProcessor::MAX1 + b1);
    }
    
    util::quadchar PacketProcessor::ENumber(unsigned int number)
    {
        std::size_t throwaway;
    
        return PacketProcessor::ENumber(number, throwaway);
    }
    
    util::quadchar PacketProcessor::ENumber(unsigned int number, std::size_t &size)
    {
        util::quadchar bytes(254);
        unsigned int onumber = number;
    
        if (onumber >= PacketProcessor::MAX3)
        {
            bytes[3] = number / PacketProcessor::MAX3 + 1;
            number = number % PacketProcessor::MAX3;
        }
    
        if (onumber >= PacketProcessor::MAX2)
        {
            bytes[2] = number / PacketProcessor::MAX2 + 1;
            number = number % PacketProcessor::MAX2;
        }
    
        if (onumber >= PacketProcessor::MAX1)
        {
            bytes[1] = number / PacketProcessor::MAX1 + 1;
            number = number % PacketProcessor::MAX1;
        }
    
        bytes[0] = number + 1;
    
        for (int i = 3; i >= 0; --i)
        {
            if (i == 0)
            {
                size = 1;
                break;
            }
            else if (bytes[i] > 0)
            {
                size = i + 1;
                break;
            }
        }
    
        return bytes;
    }
    
    unsigned short PacketProcessor::PID(PacketFamily b1, PacketAction b2)
    {
        return b1 + b2*256;
    }
    
    util::pairchar PacketProcessor::EPID(unsigned short pid)
    {
        util::pairchar bytes;
    
        bytes[1] = pid % 256;
        bytes[0] = pid / 256;
    
        return bytes;
    }
    
    PacketReader::PacketReader(const std::string &data)
    {
        this->data = data;
        this->length = data.length();
    
    //    for (std::size_t i = 0; i < data.length(); ++i)
    //    {
    //        printf("%s\n", data.c_str());
    //        printf("%i_", int(data[i]));
    //        printf("\n");
    //    }
    }
    
    std::size_t PacketReader::Length()
    {
        return this->length;
    }
    
    std::size_t PacketReader::Remaining()
    {
        return this->data.length();
    }
    
    unsigned char PacketReader::PeekByte()
    {
        unsigned char ret;
    
        if (this->data.length() < 1)
        {
            return 0;
        }
    
        ret = this->data[0];
    
        return ret;
    }
    
    unsigned char PacketReader::PeekChar()
    {
        unsigned char ret;
    
        if (this->data.length() < 1)
        {
            return 0;
        }
    
        ret = PacketProcessor::Number(this->data[0]);
    
        return ret;
    }
    
    unsigned short PacketReader::PeekShort()
    {
        unsigned short ret;
    
        if (this->data.length() < 1)
        {
            return 0;
        }
    
        if (this->data.length() < 2)
        {
            ret = PacketProcessor::Number(this->data[0]);
            this->data.erase(0, 1);
            return ret;
        }
    
        ret = PacketProcessor::Number(this->data[0], this->data[1]);
    
        return ret;
    }
    
    unsigned int PacketReader::PeekThree()
    {
        unsigned int ret;
    
        if (this->data.length() < 1)
        {
            return 0;
        }
    
        if (this->data.length() < 2)
        {
            ret = PacketProcessor::Number(this->data[0]);
            this->data.erase(0, 1);
            return ret;
        }
    
        if (this->data.length() < 3)
        {
            ret = PacketProcessor::Number(this->data[0], this->data[1]);
            this->data.erase(0, 2);
            return ret;
        }
    
        ret = PacketProcessor::Number(this->data[0], this->data[1], this->data[2]);
    
        return ret;
    }
    
    unsigned int PacketReader::PeekInt()
    {
        unsigned int ret;
    
        if (this->data.length() < 1)
        {
            return 0;
        }
    
        if (this->data.length() < 2)
        {
            ret = PacketProcessor::Number(this->data[0]);
            this->data.erase(0, 1);
            return ret;
        }
    
        if (this->data.length() < 3)
        {
            ret = PacketProcessor::Number(this->data[0], this->data[1]);
            this->data.erase(0, 2);
            return ret;
        }
    
        if (this->data.length() < 4)
        {
            ret = PacketProcessor::Number(this->data[0], this->data[1], this->data[2]);
            this->data.erase(0, 3);
            return ret;
        }
    
        ret = PacketProcessor::Number(this->data[0], this->data[1], this->data[2], this->data[3]);
    
        return ret;
    }
    
    unsigned char PacketReader::GetByte()
    {
        unsigned char ret;
    
        if (this->data.length() < 1)
        {
            return 0;
        }
    
        ret = this->data[0];
        this->data.erase(0, 1);
    
        return ret;
    }
    
    unsigned char PacketReader::GetChar()
    {
        unsigned char ret;
    
        if (this->data.length() < 1)
        {
            return 0;
        }
    
        ret = PacketProcessor::Number(this->data[0]);
        this->data.erase(0, 1);
    
        return ret;
    }
    
    unsigned short PacketReader::GetShort()
    {
        unsigned short ret;
    
        if (this->data.length() < 1)
        {
            return 0;
        }
    
        if (this->data.length() < 2)
        {
            ret = PacketProcessor::Number(this->data[0]);
            this->data.erase(0, 1);
            return ret;
        }
    
        ret = PacketProcessor::Number(this->data[0], this->data[1]);
        this->data.erase(0, 2);
    
        return ret;
    }
    
    unsigned int PacketReader::GetThree()
    {
        unsigned int ret;
    
        if (this->data.length() < 1)
        {
            return 0;
        }
    
        if (this->data.length() < 2)
        {
            ret = PacketProcessor::Number(this->data[0]);
            this->data.erase(0, 1);
            return ret;
        }
    
        if (this->data.length() < 3)
        {
            ret = PacketProcessor::Number(this->data[0], this->data[1]);
            this->data.erase(0, 2);
            return ret;
        }
    
        ret = PacketProcessor::Number(this->data[0], this->data[1], this->data[2]);
        this->data.erase(0, 3);
    
        return ret;
    }
    
    unsigned int PacketReader::GetInt()
    {
        unsigned int ret;
    
        if (this->data.length() < 1)
        {
            return 0;
        }
    
        if (this->data.length() < 2)
        {
            ret = PacketProcessor::Number(this->data[0]);
            this->data.erase(0, 1);
            return ret;
        }
    
        if (this->data.length() < 3)
        {
            ret = PacketProcessor::Number(this->data[0], this->data[1]);
            this->data.erase(0, 2);
            return ret;
        }
    
        if (this->data.length() < 4)
        {
            ret = PacketProcessor::Number(this->data[0], this->data[1], this->data[2]);
            this->data.erase(0, 3);
            return ret;
        }
    
        ret = PacketProcessor::Number(this->data[0], this->data[1], this->data[2], this->data[3]);
        this->data.erase(0, 4);
    
        return ret;
    }
    
    std::string PacketReader::GetFixedString(std::size_t length)
    {
        std::string ret;
    
        if (length == 0 || this->data.length() < length)
        {
            return ret;
        }
    
        ret = this->data.substr(0, length);
        this->data.erase(0, length);
    
        return ret;
    }
    
    std::string PacketReader::GetBreakString(unsigned char breakchar)
    {
        std::string ret;
        std::size_t length;
    
        length = this->data.find_first_of(breakchar);
    
        if (length == std::string::npos)
        {
            return ret;
        }
    
        ret = this->data.substr(0, length);
        this->data.erase(0, length+1);
    
        return ret;
    }
    
    std::string PacketReader::GetEndString()
    {
        std::string ret = this->data;
    
        this->data.erase();
    
        return ret;
    }
    
    PacketBuilder::PacketBuilder()
    {
        this->length = 0;
        this->id = 0;
    }
    
    PacketBuilder::PacketBuilder(unsigned short id)
    {
        this->length = 0;
        this->SetID(id);
    }
    
    PacketBuilder::PacketBuilder(PacketFamily family, PacketAction action)
    {
        this->length = 0;
        this->SetID(family, action);
    }
    
    unsigned short PacketBuilder::SetID(unsigned short id)
    {
        if (id == 0)
        {
            id = PacketProcessor::PID(PACKET_F_INIT, PACKET_A_INIT);
        }
    
        this->id = id;
    
        return this->id;
    }
    
    unsigned short PacketBuilder::SetID(PacketFamily family, PacketAction action)
    {
        return this->SetID(PacketProcessor::PID(family, action));
    }
    
    unsigned char PacketBuilder::AddByte(unsigned char byte)
    {
        ++this->length;
        this->data += byte;
        return byte;
    }
    
    unsigned char PacketBuilder::AddChar(unsigned char num)
    {
        util::quadchar bytes;
        ++this->length;
        bytes = PacketProcessor::ENumber(num);
        this->data += bytes[0];
        return num;
    }
    
    unsigned short PacketBuilder::AddShort(unsigned short num)
    {
        util::quadchar bytes;
        this->length += 2;
        bytes = PacketProcessor::ENumber(num);
        this->data += bytes[0];
        this->data += bytes[1];
        return num;
    }
    
    unsigned int PacketBuilder::AddThree(unsigned int num)
    {
        util::quadchar bytes;
        this->length += 3;
        bytes = PacketProcessor::ENumber(num);
        this->data += bytes[0];
        this->data += bytes[1];
        this->data += bytes[2];
        return num;
    }
    
    unsigned int PacketBuilder::AddInt(unsigned int num)
    {
        util::quadchar bytes;
        this->length += 4;
        bytes = PacketProcessor::ENumber(num);
        this->data += bytes[0];
        this->data += bytes[1];
        this->data += bytes[2];
        this->data += bytes[3];
        return num;
    }
    
    unsigned int PacketBuilder::AddVar(int min, int max, unsigned int num)
    {
        if (min <= 1)
        {
            if (max <= 1 || num < PacketProcessor::MAX1)
            {
                this->AddChar(num);
                return num;
            }
        }
    
        if (min <= 2)
        {
            if (max <= 2 || num < PacketProcessor::MAX2)
            {
                this->AddShort(num);
                return num;
            }
        }
    
        if (min <= 3)
        {
            if (max <= 3 || num < PacketProcessor::MAX3)
            {
                this->AddThree(num);
                return num;
            }
        }
    
        this->AddInt(num);
        return num;
    }
    
    const std::string &PacketBuilder::AddString(const std::string &str)
    {
        this->length += str.length();
        this->data += str;
    
        return str;
    }
    
    const std::string &PacketBuilder::AddBreakString(const std::string &str, unsigned char breakchar)
    {
        std::string tempstr(str);
        std::size_t breakin = tempstr.find_first_of(breakchar);
        while (breakin != std::string::npos)
        {
            tempstr[breakin] = 'y';
            breakin = tempstr.find_first_of(breakchar, breakin+1);
        }
    
        this->length += tempstr.length() + 1;
        this->data += tempstr;
        this->data += breakchar;
    
        return str;
    }
    
    void PacketBuilder::Reset()
    {
        this->length = 0;
        this->data.erase();
    }
    
    std::string PacketBuilder::Get()
    {
        std::string retdata;
        util::pairchar id = PacketProcessor::EPID(this->id);
        util::quadchar length = PacketProcessor::ENumber(this->length + 2 + (id[1] != 255));
    
        retdata += length[0];
        retdata += length[1];
        retdata += id[0];
        retdata += id[1];
        retdata += this->data;
    
        return retdata;
    }
    
    PacketBuilder::operator std::string()
    {
        return this->Get();
    }
    \\\\\\\\\\\\\\\\\\\\\\\


    I'm trying to change that into the tutorial below via next post
    Last edited by kotacoder; 06-04-2021 at 11:08 AM.

  7. #7
    Registered User
    Join Date
    Jun 2021
    Posts
    31
    Code:
     
    
    in packet.cpp under the includes add unsigned short seqstart; unsigned char seqval = 1; unsigned short Sequence() { unsigned short val = seqval; if (++seqval >= 10) { seqval = 0;//was 0 } return seqstart + val; } void SetSeqStart(unsigned short val) { seqstart = val; } and remove these variables and functions PacketProcessor::seqstartPacketProcessor::seqvalunsigned short PacketProcessor::Sequence() { unsigned short val = seqval; if (++seqval >= 10) { seqval = 0;//was 0 } return seqstart + val; } void PacketProcessor::SetSeqStart(unsigned short val) { seqstart = val; } Replace your packet encode function with this std::string PacketProcessor::Encode(const std::string &rawstr) { std::string str = this->DickWinderE(rawstr); std::string newstr; int length = str.length(); int i = 2; int ii = 2; newstr.resize(length); newstr[0] = str[0]; newstr[1] = str[1]; while (i < length) { newstr[i] = (unsigned char)str[ii++] ^ 0x80; i += 2; } i = length - 1; if (length % 2) { --i; } while (i >= 2) { newstr[i] = (unsigned char)str[ii++] ^ 0x80; i -= 2; } for (int i = 2; i < length; ++i) { if (static_cast<unsigned char>(newstr[i]) == 128) { newstr[i] = 0; } else if (newstr[i] == 0) { newstr[i] = 128; } } return newstr; } Near the bottom replace your PacketBulder::Get function with this std::string PacketBuilder::Get() { std::string retdata; util::pairchar id = PacketProcessor::EPID(this->id); int extra = (id[1] != 255); unsigned short sequence = 0; int bytes_ = 1; std::string seqdata = ""; if(extra) { sequence = Sequence(); if(sequence >= 253) bytes_ = 2; util::quadchar seq_ = PacketProcessor::ENumber(sequence); if(bytes_ == 1) { seqdata += seq_[0]; } else { seqdata += seq_[0]; seqdata += seq_[1]; } } util::quadchar length = PacketProcessor::ENumber(this->length + 2 + (extra + bytes_ -1)); retdata += length[0]; retdata += length[1]; retdata += id[0]; retdata += id[1]; retdata += seqdata; retdata += this->data; return retdata; }

    Last edited by kotacoder; 06-04-2021 at 11:03 AM.

  8. #8
    and the hat of int overfl Salem's Avatar
    Join Date
    Aug 2001
    Location
    The edge of the known universe
    Posts
    38,815
    > and remove these variables and functions
    One of which seems to be
    > void PacketProcessor::SetSeqStart(unsigned short val)

    However....
    in packet.cpp under the includes add
    Code:
    unsigned short seqstart;
    unsigned char seqval = 1;
    
    unsigned short Sequence()
    {
        unsigned short val = seqval;
    
        if (++seqval >= 10)
        {
            seqval = 0;//was 0
        }
    
        return seqstart + val;
    }
    
    void SetSeqStart(unsigned short val)
    {
        seqstart = val;
    }
    Neither of these are members of your class.

    You deleted class member functions, but didn't replace them with your own.
    If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
    If at first you don't succeed, try writing your phone number on the exam paper.

  9. #9
    Registered User
    Join Date
    Jun 2021
    Posts
    31
    okay how do I go about replacing them with my own? or what exactly do I need to do to fix? sorry I'm new at coding

  10. #10
    and the hat of int overfl Salem's Avatar
    Join Date
    Aug 2001
    Location
    The edge of the known universe
    Posts
    38,815
    Normally I would suggest learning some C++ to begin with.

    But you could try making those free functions class member functions by putting PacketProcessor:: in front of the function name - you know, just like the ones you deleted.

    > I'm trying to change some of the source code around and when I do what a tutorial says
    Links please.

    Seems like a bad advice tutorial TBH.
    If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
    If at first you don't succeed, try writing your phone number on the exam paper.

  11. #11
    Registered User
    Join Date
    Jun 2021
    Posts
    31
    ty for your reply and here is the link EOSERV :: Forum :: Lounge 2.0 :: EOBOT issues I'm going to try your advice and I will let you know what happens (EDIT) so I should put it together like this right?

    unsigned short PacketProcessor::seqstart;
    unsigned char PacketProcessor::seqval = 1;

    that would be the start of the code or are you talking about something different
    Last edited by kotacoder; 06-04-2021 at 02:53 PM.

  12. #12
    and the hat of int overfl Salem's Avatar
    Join Date
    Aug 2001
    Location
    The edge of the known universe
    Posts
    38,815
    Apart from your idea of "tutorial" being "random out of context forum post".

    Start with the clean copy of PacketProcessor and all the other stuff it comes with.
    Does it compile?

    Before you start randomly deleting bits of code and trying to interpret random forum "do this to fix it" posts, you need to test what you have and figure out for yourself what works and what doesn't.

    > that would be the start of the code or are you talking about something different
    I've no idea what that author was smoking TBH.
    Code:
    unsigned short seqstart;
    unsigned char seqval = 1;
     
    unsigned short Sequence()
    {
        unsigned short val = seqval;
     
        if (++seqval >= 10)
        {
            seqval = 0;//was 0
        }
     
        return seqstart + val;
    }
    void SetSeqStart(unsigned short val)
    {
        seqstart = val;
    }
    is functionally identical to what's in the class to start with.
    Code:
    void PacketProcessor::SetSeqStart(unsigned char val)
    {
        this->seqstart = val;
    }
     
    unsigned char PacketProcessor::Sequence()
    {
        int val = this->seqval;
     
        if (++this->seqval >= 10)
        {
            this->seqval = 0;
        }
     
        return this->seqstart + val;
    }
    The only difference I can see is the sequence start changed from unsigned char to unsigned short.
    Changing just that type in a few places would have been simpler IMO.

    One thing is for sure, the necessary edits based on that post are not the whole story.

    Which goes back to my previous comment. You need to learn some C++ before you start downloading large libraries and attempting to fix them.

    So, do you want to learn, or are you just hoping for some quick fix?
    If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
    If at first you don't succeed, try writing your phone number on the exam paper.

  13. #13
    Registered User
    Join Date
    Jun 2021
    Posts
    31
    Thank you for your help and your reply it means a lot. I am looking to learn instead of a quick fix although the quick fix would be nice but I still would like to learn

  14. #14
    Registered User
    Join Date
    Jun 2021
    Posts
    31
    Are you going to be able to help me anymore?

  15. #15
    Registered User
    Join Date
    May 2009
    Posts
    4,079
    Quote Originally Posted by Salem View Post
    Start with the clean copy of PacketProcessor and all the other stuff it comes with.
    Does it compile?
    Quote Originally Posted by kotacoder View Post
    Are you going to be able to help me anymore?
    To kotacoder:

    Can you answer questions that require you to do work?
    "...a computer is a stupid machine with the ability to do incredibly smart things, while computer programmers are smart people with the ability to do incredibly stupid things. They are,in short, a perfect match.." Bill Bryson

Popular pages Recent additions subscribe to a feed

Similar Threads

  1. How covert unsigned char[4] to unsigned integer?
    By barracuda in forum C Programming
    Replies: 110
    Last Post: 02-23-2015, 04:00 AM
  2. Unsigned char array to unsigned char?
    By Kishintai in forum C Programming
    Replies: 16
    Last Post: 04-26-2013, 01:37 PM
  3. Replies: 4
    Last Post: 07-24-2012, 10:41 AM
  4. undefined reference to `RunSwmmDll(char*, char*, char*)'
    By amkabaasha in forum C++ Programming
    Replies: 1
    Last Post: 10-31-2011, 12:33 PM
  5. Replies: 2
    Last Post: 10-06-2009, 09:37 AM

Tags for this Thread