ofstream error
I keep getting below ofstream error.
[Error] no matching function for call to 'std::basic_ofstream<char>:pen(std:
What could be wrong here? Is it compiler issue? How to fix it?
Below is my code.
Code:ofstream outputFile; ofstream fs; // create a name for the file output std::string filename = "test.csv"; /int i; int main(int argc, char** argv) { // create and open the .csv file fs.open(outputFile,filename);
std::basic_fstream<CharT,Traits>::open - cppreference.com
You need at least C++11 to open a file with a filename stored in a std::string.
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
I think my compiler support c++11.I checked the Compiler settings and it shows "Language standard (-std) ISO C++ 11. Is that what you meant?
should i change code this way?
Code:ofstream outputFile; //ofstream fs; // create a name for the file output std::string filename = "test.csv"; std::ofstream fs; int main(int argc, char** argv) { fs.open(filename);
Yes, but you have another issue: the parameters are wrong. It should have been:
Notice that I declared fs to be a local variable, and initialised it at the same time, i.e., declare variables near first use in as local a scope as feasible. I let filename remain at file scope, but changed it to be const: this way it is merely a constant rather than adding to global state.Code:// create a name for the file output const std::string filename = "test.csv"; int main(int argc, char** argv) { // create and open the .csv file ofstream fs(filename);
Look up a C++ Reference and learn How To Ask Questions The Smart WayOriginally Posted by Bjarne Stroustrup (2000-10-14)
With above changes, output file (test.csv) doesn't even get created.
Hi laserlight
can you help me suggest a working code?
I literally posted code.
Look up a C++ Reference and learn How To Ask Questions The Smart Way
I still got the same ofstream error at this line --> fs.open( outputFile, filename);
Code:ofstream outputFile; //ofstream fs; // create a name for the file output const std::string filename = "test.csv"; std::ofstream fs; int main(int argc, char** argv) { fs.open( outputFile, filename);
You have two ofstream objects: outputFile and fs. You only have one output file. Pick one. That is, if you want to use outputFile, then delete fs. If you want to use fs, then delete outputFile. What you're doing right now is opening fs and then using outputFile. Of course that doesn't work. It is like opening a bank account at Bank A and another account at Bank B, depositing all your money into the account at Bank A, then asking why your account at Bank B is empty.
The other thing: don't use global variables. Force yourself to use local variables, even when global variables seem far more convenient. This will develop your discipline to think in terms of local state, which in turn will allow you to write larger and larger programs without these programs becoming very difficult to maintain.
Look up a C++ Reference and learn How To Ask Questions The Smart Way
