Class error

[sash_007]

Hello friends,
I am trying to access Birthday object from peoples class and display it in main but why the program is getting compilation error?

here is my code
main.cpp

#include<iostream>#include "Birthday.h"
#include "Birthday.cpp"
#include "People.h"
#include "People.cpp"
using namespace std;




int main(){
 Birthday birthObj(11,5,1992);
 People JasonSmith("Jason",birthObj);
 JasonSmith.printInfo();




return 0;
}

Birthday.h

#ifndef BIRTHDAY_H#define BIRTHDAY_H




class Birthday
{
    public:
        Birthday(int m,int d,int y);
        void printDate();


    private:
        int month;
        int day;
        int year;
};


#endif // BIRTHDAY_H

Birthday.cpp

#include "Birthday.h"#include<iostream>
using namespace std;
Birthday::Birthday(int m,int d,int y)
{
  month = m;
  day = d;
  year= y;
}


void Birthday::printDate(){


  cout<<month<<"/ "<<day<<"/ "<<year<<endl;
}

People.h

#ifndef PEOPLE_H#define PEOPLE_H


#include<string>
#include "Birthday.h"
#include "Birthday.cpp"
using namespace std;
class People
{
    public:
        People(string x,Birthday bo);
        void printInfo();


    private:
        string name;
        Birthday dateOfBirth;
};


#endif // PEOPLE_H

People.cpp

#include "People.h"#include "Birthday.h"
#include<iostream>
using namespace std;


People::People(string x,Birthday bo)
: name(x),dateOfBirth(bo)
{


}


void People::printInfo(){
 cout<<name<<" was born on ";
 dateOfBirth.printDate();


}

Please be easy on me as i am still learning c++

[jimblumberg]

but why the program is getting compilation error?

What exactly is this compile error?

Also #including a .cpp file is usually a mistake. You should add the .cpp files to your project to be properly compiled, not #included.

[sash_007]

error is in Birthday.cpp



without including .cpp files the program is not even running no errors either

[jimblumberg]

As I said in my previous post this error is being caused by #including that source file. You need be using a project and then add the .cpp files to your project for compiling.

without including .cpp files the program is not even running no errors either

Did you add the .cpp files to the project and re-build the sources?

[sash_007]

you mean i have to make a new project defining new paths

from here



and then compile ?

[sash_007]

do note since i am creating mutipleclass files for each topic i learn i am making seperate folders fore each and then creating class inside that folder

in this case its composition folder

in my last tutorial where i learnt member initializer
i made separate folder for that and made seperate main,header and .cpp file and it compiled just fine

code of member initializer

#include<iostream>#include "Sally.h"
#include "Sally.cpp"
using namespace std;




int main(){


Sally so(45,76);
so.print();


return 0;
}

header file

#ifndef SALLY_H#define SALLY_H




class Sally
{
    public:
        Sally(int a,int b);
        void print();
    protected:


    private:
        int regVar;
        const int constVar;
};


#endif // SALLY_H

sally.cpp

#include "Sally.h"#include<iostream>


using namespace std;




Sally::Sally(int a,int b)
//member intializer is needed to call constant variables
: regVar(a),
constVar(b)
{


}


void Sally::print(){
 cout<<"regular variable is "<<regVar<<endl;
 cout<<"constant variable is "<<constVar<<endl;
}

[Salem]

You have multiple #include "somefile.cpp" lines.

#include<iostream>
#include "Sally.h"
#include "Sally.cpp" //!!<< This is wrong!

You add the .h and .cpp files to your project in the IDE, then it will do the right thing when it comes to compiling.


So you end up with Birthday.cpp, People.cpp, main.cpp (and any others) shown in the sources "folder" in the IDE.
And likewise for any header files.

[sash_007]

ok thanks i will try this

[sash_007]

ok i made new project watermelon

and added all source and header files but still getting error?

[jimblumberg]

Okay, where is your code for main?

Please cut and paste the code into a post (inside code tags), pictures tend to be harder to read.

It would also help if you cut and pasted the error messages, your picture is cutting a lot of the error messages off.

[sash_007]

main.cpp

#include<iostream>#include "Birthday.h"


#include "People.h"


using namespace std;




int main(){
 Birthday birthObj(11,5,1992);
 People JasonSmith("Jason",birthObj);
 JasonSmith.printInfo();




return 0;
}

birthday.cpp

#include "Birthday.h"#include<iostream>
using namespace std;
Birthday::Birthday(int m,int d,int y)
{
  month = m;
  day = d;
  year= y;
}


void Birthday::printDate(){


  cout<<month<<"/ "<<day<<"/ "<<year<<endl;
}

birthday.h

#ifndef BIRTHDAY_H#define BIRTHDAY_H




class Birthday
{
    public:
        Birthday(int m,int d,int y);
        void printDate();






    private:
        int month;
        int day;
        int year;
};


#endif // BIRTHDAY_H

people.cpp

#include "People.h"#include "Birthday.h"
#include<iostream>
using namespace std;


People::People(string x,Birthday bo)
: name(x),dateOfBirth(bo)
{


}


void People::printInfo(){
 cout<<name<<" was born on ";
 dateOfBirth.printDate();


}

people.h

#ifndef PEOPLE_H#define PEOPLE_H


#include<string>
#include "Birthday.h"
#include "Birthday.cpp"
using namespace std;
class People
{
    public:
        People(string x,Birthday bo);
        void printInfo();


    private:
        string name;
        Birthday dateOfBirth;
};


#endif // PEOPLE_H

multiple definition error

[sash_007]

ok things worked when i removed

#include "Birthday.cpp"

from people.h

new people.h

 #ifndef PEOPLE_H#define PEOPLE_H


#include<string>
#include "Birthday.h"


using namespace std;
class People
{
    public:
        People(string x,Birthday bo);
        void printInfo();


    private:
        string name;
        Birthday dateOfBirth;
};


#endif // PEOPLE_H

[jimblumberg]

Please cut and paste your error messages into a post. That picture is not showing everything.

[sash_007]

Please cut and paste your error messages into a post. That picture is not showing everything.

i got this working (check my last reply)thank you and Salem for helping me learning how to add files in project and not to include .cpp files like i did before.. much appreciated