Thread: Logical error: I'm not getting expected result

Please check the code and output.
I've checked again and again but could not sort out the flaw.
Kindly help please!

Code:

#include<iostream>
#include<cstdlib>


using namespace std;


class Time{
	
	private:
	
		int hours;		
		int minutes;	
		int seconds;	
	
	public:
	
		Time( int h, int m, int s ){				
		setTime(h, m, s);					
		}
		
		void setTime(int h, int m, int s){
			setHours(h);			
			setMinutes(m);			
			setSeconds(s);			
		}
		
		void setHours(int h){
			hours = (h >= 0 && h < 24) ? h : 0 ;
		}
		
		void setMinutes(int m){
			minutes = (m >= 0 && m < 60) ? m : 0 ;
		}
		
		void setSeconds(int s){
			hours = (s >= 0 && s < 24) ? s : 0 ;
		}
		
		
		int getHours() const{
			return hours;
		}
		
		int getMinutes() const{
			return minutes;
		}
		
		int getSeconds() const{
			return seconds;
		}
		
		void printTime() const{
			cout << hours << ":" << minutes << ":" << seconds << endl;
		}
		
		~Time() {					
		
		}
};


int main(){
	
	Time wakeUp(6, 45, 0);		
	const Time noon(12, 0, 0);			
	wakeUp.printTime();							
	noon.printTime();								
	system("pause");
	return 0;
	
}

Originally Posted by Salem

> hours = (s >= 0 && s < 24) ? s : 0 ;
Try setting seconds.
Try with 60 seconds.

Still same issue

Originally Posted by rm82co

Still same issue

Well... What Salem said is that your code:

Code:

void setSeconds(int s){ hours = (s >= 0 && s < 24) ? s : 0; }

should be:

Code:

void setSeconds(int s){ seconds = (s >= 0 && s < 60) ? s : 0; }

Code:

#include<iostream>
#include<cstdlib>


using namespace std;


class Time{
	
	private:
	
		int hours;		
		int minutes;	
		int seconds;	
	
	public:
	
		Time( int h, int m, int s ){				
		setTime(h, m, s);					
		}
		
	
		
		void setTime(int h, int m, int s){
			setHours(h);			
			setMinutes(m);			
			setSeconds(s);			
		}
		
		void setHours(int h){
			hours = (h >= 0 && h < 24) ? h : 0 ;
			cout << "hours: " << hours << endl;
			
		}
		
		void setMinutes(int m){
			minutes = (m >= 0 && m < 60) ? m : 0 ;
			cout << "minutes: " << minutes << endl;
		}
		
		void setSeconds(int s){
			hours = (s >= 0 && s < 60) ? s : 0 ;
			cout << "seconds: " << seconds << endl;
		}
		
		
		
		int getHours() const{
			
			return hours;
		}
		
		int getMinutes() const{
			return minutes;
		}
		
		int getSeconds() const{
			return seconds;
		}
		
		
		
		void printTime() const{
			cout << hours << ":" << minutes << ":" << seconds << endl;
		}
		
			
		}
};


int main(){
	
	const Time wakeUp(6, 45, 0);		
	const Time noon(12, 0, 0);			
										
									
	wakeUp.printTime();					
	noon.printTime();			
	system("pause");
	return 0;
	
}

I have modified code to find errors. Please check and guide me where is the problem. I am still not being able to find

Originally Posted by rm82co

Yup I have done it in this way. Still same issue.

I have done Sir, thank you very much. It is working now.

Thank you very much