Thread: Finding mix & max of a calculated variable from an input file

Originally Posted by laserlight

Simple tip until you're better at C++ such that you can ignore it and know exactly what went wrong: always use braces, even when the body of the if statement etc is only one statement. If you always do this, when the body of the if statement should be two statements, you won't make the mistake of having it apply to only the first statement.

Thank you laserlight. Simple tip for me to figure out but such an obvious mistake I discovered in my code... it works now excellently. One last question; I initialized my flag variable to be equal to 0 (false). Inside the loop, after everything executes; I set flag = 1 (true). The program only works correctly if I set flag = 1 at the end of the loop; why do I have to set my bool to true for it to work correctly?

Code:

 
        if (flag = 0)

        max = index;

        min = index;

This only initializes max conditionally. min will be set to index every time. Put the two in brackets

Originally Posted by laserlight

That's why you need to give the flag a descriptive name: what's the flag for, what does true/false for the flag denote? Once you figure that out, it will become obvious why you need to set it somewhere in the loop after you have set the initial values for max and min.

Excellet advice again. I totally get it now. Thank you for the help!